Skip to content

Conversation

@absolute8511
Copy link
Contributor

Which Issue(s) This PR Fixes

Fixes #9792

Brief Description

How Did You Test This Change?

Change-Id: I7d7998c2c1b3dd75efc8c83f0e18a094f75dda35
Change-Id: Ibd3e2d21e6178315f087686db71528b6873a4439
@absolute8511 absolute8511 changed the title avoid create topic meta info in read only operation [ISSUE #9792] avoid create topic meta info in read only operation Oct 30, 2025
@qianye1001
Copy link
Contributor

RocksDB CQ implements lazy loading. Removing the loading operation at read time could prevent access to messages that are stored exclusively in RocksDB.

Change-Id: Iac412019d3823949b14c8bf1e32d7c51d2355df6
@absolute8511
Copy link
Contributor Author

absolute8511 commented Nov 3, 2025

RocksDB CQ implements lazy loading. Removing the loading operation at read time could prevent access to messages that are stored exclusively in RocksDB.

OK, I kept the getConsumeQueue not changed in RocksDB CQ.

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.31%. Comparing base (204b251) to head (ad129aa).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...apache/rocketmq/store/queue/ConsumeQueueStore.java 44.00% 10 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9793      +/-   ##
=============================================
- Coverage      48.37%   48.31%   -0.07%     
+ Complexity     12246    12237       -9     
=============================================
  Files           1314     1314              
  Lines          93668    93685      +17     
  Branches       12011    12018       +7     
=============================================
- Hits           45312    45263      -49     
- Misses         42762    42823      +61     
- Partials        5594     5599       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Change-Id: I9f1731cd1a8b763dff54b8977e1abeda8e1901ee
Change-Id: I34dd2813580335f764ceb969714ebe59739af613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] avoid recreate topic in ConsumeQueueTable in readonly operation for deleted topic

3 participants