Double-Checked Locking

[QiAnXinCodeSafe]

royale-compiler/compiler/src/main/java/org/apache/royale/compiler/internal/scopes/ASScopeCache.java

Lines 224 to 232 in 6f75df7

	if (map == null)
	{
	if ((CompilerDiagnosticsConstants.diagnostics & CompilerDiagnosticsConstants.ASSCOPECACHE) == CompilerDiagnosticsConstants.ASSCOPECACHE)
	System.out.println("ASScopeCache waiting for lock in getScopeChainMap");
	synchronized (this)
	{
	// Check again, in case another thread updated the map first
	map = findPropCache != null ? findPropCache.get() : null;
	if (map == null)

Double-Checked Locking is widely cited and used as an efficient method for implementing lazy initialization in a multithreaded environment.
Unfortunately, it will not work reliably in a platform independent way when implemented in Java, without additional synchronization.

[carlosrovira]

Hi, thanks for the information. Could you please let us know as a better way of doing it submitting a patch. We'll be glad to integrate any improvement.
thanks

[QiAnXinCodeSafe]

Hi, thanks for the information. Could you please let us know as a better way of doing it submitting a patch. We'll be glad to integrate any improvement.
thanks
Modify the variable map with volatile.

[carlosrovira]

Hi @QiAnXinCodeSafe, if you can submit a Pull Request it would be better and would make your collaborations and out testing more productive. Could you send as a PR for this issue?
thanks