Skip to content

Commit 014243b

Browse files
hantmachantmac
committed
fix some comments
1 parent 778954f commit 014243b

File tree

7 files changed

+7
-61
lines changed

7 files changed

+7
-61
lines changed

‎docs/en/connector-v2/sink/Databend.md‎

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ The Databend sink internally implements bulk data import through stage attachmen
3737
| Name | Type | Required | Default Value | Description |
3838
|------|------|----------|---------------|---------------------------------------------|
3939
| url | String | Yes | - | Databend JDBC connection URL |
40-
| user | String | Yes | - | Databend database username |
40+
| username | String | Yes | - | Databend database username |
4141
| password | String | Yes | - | Databend database password |
4242
| database | String | No | - | Databend database name, defaults to the database name specified in the connection URL |
4343
| table | String | No | - | Databend table name |
@@ -114,7 +114,7 @@ source {
114114
sink {
115115
Databend {
116116
url = "jdbc:databend://localhost:8000"
117-
user = "root"
117+
username = "root"
118118
password = ""
119119
database = "default"
120120
table = "target_table"
@@ -129,7 +129,7 @@ sink {
129129
sink {
130130
Databend {
131131
url = "jdbc:databend://localhost:8000"
132-
user = "root"
132+
username = "root"
133133
password = ""
134134
database = "default"
135135
table = "target_table"
@@ -144,7 +144,7 @@ sink {
144144
sink {
145145
Databend {
146146
url = "jdbc:databend://localhost:8000"
147-
user = "root"
147+
username = "root"
148148
password = ""
149149
database = "default"
150150
table = "target_table"
@@ -160,14 +160,13 @@ sink {
160160
sink {
161161
Databend {
162162
url = "jdbc:databend://databend:8000/default?ssl=false"
163-
user = "root"
163+
username = "root"
164164
password = ""
165165
database = "default"
166166
table = "sink_table"
167167
168168
# Enable CDC mode
169169
batch_size = 1
170-
interval = 3
171170
conflict_key = "id"
172171
allow_delete = true
173172
}

‎seatunnel-connectors-v2/connector-databend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/config/DatabendOptions.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class DatabendOptions {
3737
.withDescription("Whether to use SSL for the Databend connection");
3838

3939
public static final Option<String> USERNAME =
40-
Options.key("user")
40+
Options.key("username")
4141
.stringType()
4242
.noDefaultValue()
4343
.withDescription("The username for Databend database authentication");

‎seatunnel-connectors-v2/connector-databend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/config/DatabendSinkConfig.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ public static DatabendSinkConfig of(ReadonlyConfig config) {
6666
.withAutoCommit(config.get(DatabendOptions.AUTO_COMMIT))
6767
.withBatchSize(config.get(DatabendOptions.BATCH_SIZE))
6868
.withExecuteTimeoutSec(config.get(DatabendSinkOptions.EXECUTE_TIMEOUT_SEC))
69-
.withInterval(config.get(DatabendSinkOptions.INTERVAL))
7069
.withConflictKey(config.get(DatabendSinkOptions.CONFLICT_KEY))
7170
.withAllowDelete(config.get(DatabendSinkOptions.ALLOW_DELETE))
7271
.build();

‎seatunnel-connectors-v2/connector-databend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/config/DatabendSinkOptions.java‎

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,6 @@ public class DatabendSinkOptions {
5454
.defaultValue(1000)
5555
.withDescription("Batch size for CDC merge operations");
5656

57-
public static final Option<Integer> INTERVAL =
58-
Options.key("interval")
59-
.intType()
60-
.defaultValue(30)
61-
.withDescription("Interval in seconds for CDC merge operations");
62-
6357
public static final Option<String> CONFLICT_KEY =
6458
Options.key("conflict_key")
6559
.stringType()

‎seatunnel-connectors-v2/connector-databend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSink.java‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -196,11 +196,6 @@ public Optional<SaveModeHandler> getSaveModeHandler() {
196196
}
197197
}
198198

199-
@Override
200-
public Optional<Serializer<Void>> getWriterStateSerializer() {
201-
return Optional.empty();
202-
}
203-
204199
private boolean executeSql(Connection connection, String sql) {
205200
try (java.sql.Statement statement = connection.createStatement()) {
206201
log.info("Executing SQL: {}", sql);
@@ -271,11 +266,6 @@ public Optional<Serializer<DatabendSinkCommitterInfo>> getCommitInfoSerializer()
271266
return Optional.of(new DefaultSerializer<>());
272267
}
273268

274-
@Override
275-
public Optional<CatalogTable> getWriteCatalogTable() {
276-
return SeaTunnelSink.super.getWriteCatalogTable();
277-
}
278-
279269
@Override
280270
public void setJobContext(JobContext jobContext) {
281271
this.jobContext = jobContext;

‎seatunnel-connectors-v2/connector-databend/src/main/java/org/apache/seatunnel/connectors/seatunnel/databend/sink/DatabendSinkWriter.java‎

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -222,41 +222,6 @@ private void initTraditionalMode(String database, String table) throws SQLExcept
222222
}
223223
}
224224

225-
// This method is no longer needed as raw table creation is handled by
226-
// DatabendSinkAggregatedCommitter
227-
// private void createRawTable(String database) throws SQLException {
228-
// String createTableSql =
229-
// String.format(
230-
// "CREATE TABLE %s.%s ("
231-
// + " id VARCHAR(255),"
232-
// + " table_name VARCHAR(255),"
233-
// + " raw_data JSON,"
234-
// + " add_time TIMESTAMP,"
235-
// + " action STRING"
236-
// + ")",
237-
// database, rawTableName);
238-
//
239-
// try (Statement stmt = connection.createStatement()) {
240-
// log.info("Creating raw table with SQL: {}", createTableSql);
241-
// stmt.execute(createTableSql);
242-
// log.info("Raw table {} created successfully", rawTableName);
243-
// }
244-
// }
245-
246-
// This method is no longer needed as stream creation is handled by
247-
// DatabendSinkAggregatedCommitter
248-
// private void createStream(String database) throws SQLException {
249-
// String createStreamSql =
250-
// String.format(
251-
// "CREATE STREAM %s.%s ON TABLE %s.%s",
252-
// database, streamName, database, rawTableName);
253-
//
254-
// try (Statement stmt = connection.createStatement()) {
255-
// log.info("Creating stream with SQL: {}", createStreamSql);
256-
// stmt.execute(createStreamSql);
257-
// log.info("Stream {} created successfully", streamName);
258-
// }
259-
// }
260225

261226
private String generateInsertRawSql(String database) {
262227
return String.format(

‎seatunnel-e2e/seatunnel-connector-v2-e2e/connector-databend-e2e/src/test/resources/databend/fake_to_databend_cdc.conf‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,13 @@ source {
7979
sink {
8080
Databend {
8181
url = "jdbc:databend://databend:8000/default?ssl=false"
82-
user = "root"
82+
username = "root"
8383
password = ""
8484
database = "default"
8585
table = "sink_table"
8686

8787
# Enable CDC mode
8888
batch_size = 1
89-
interval = 3
9089
conflict_key = "id"
9190
allow_delete = true
9291
}

0 commit comments

Comments
 (0)