Skip to content

Conversation

@dyp12
Copy link
Contributor

@dyp12 dyp12 commented Nov 26, 2025

Purpose of this pull request

#8816 add fluss sink first

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@davidzollo davidzollo requested a review from Copilot November 26, 2025 15:26
Copilot finished reviewing on behalf of davidzollo November 26, 2025 15:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Fluss connector to SeaTunnel, implementing a sink connector to write data to Fluss, a streaming storage system. The implementation includes support for the timestamp_tz (TIMESTAMP_TZ) data type to handle timezone-aware timestamps.

Key changes:

  • Adds Fluss sink connector with support for both upsert and append modes
  • Implements JSON serialization/deserialization for OffsetDateTime (TIMESTAMP_TZ type)
  • Provides E2E tests for single and multi-table scenarios

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/RowToJsonConverters.java Adds conversion support for TIMESTAMP_TZ to JSON using ISO_OFFSET_DATE_TIME formatter
seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/JsonToRowConverters.java Adds conversion support from JSON to OffsetDateTime for TIMESTAMP_TZ type
seatunnel-formats/seatunnel-format-json/src/test/java/org/apache/seatunnel/format/json/JsonRowDataSerDeSchemaTest.java Adds test coverage for TIMESTAMP_TZ serialization/deserialization
seatunnel-connectors-v2/connector-fluss/src/main/java/org/apache/seatunnel/connectors/seatunnel/fluss/sink/FlussSinkWriter.java Implements the core sink writer with type conversion logic including TIMESTAMP_TZ support
seatunnel-connectors-v2/connector-fluss/src/main/java/org/apache/seatunnel/connectors/seatunnel/fluss/sink/FlussSink.java Main sink class implementing multi-table support
seatunnel-connectors-v2/connector-fluss/src/main/java/org/apache/seatunnel/connectors/seatunnel/fluss/sink/FlussSinkFactory.java Factory class for creating Fluss sink instances
seatunnel-connectors-v2/connector-fluss/src/main/java/org/apache/seatunnel/connectors/seatunnel/fluss/config/FlussBaseOptions.java Configuration options for Fluss connector
seatunnel-connectors-v2/connector-fluss/pom.xml Maven dependencies for Fluss connector
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-fluss-e2e/src/test/java/org/apache/seatunnel/e2e/connector/fluss/FlussSinkIT.java E2E integration test for Fluss sink
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-fluss-e2e/pom.xml Maven dependencies for E2E tests
seatunnel-connectors-v2/pom.xml Adds connector-fluss module
seatunnel-e2e/seatunnel-connector-v2-e2e/pom.xml Adds connector-fluss-e2e module
seatunnel-dist/pom.xml Includes connector-fluss in distribution
plugin-mapping.properties Maps Fluss sink to connector-fluss module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@davidzollo
Copy link
Contributor

davidzollo commented Nov 27, 2025

CI failed, please check

@davidzollo
Copy link
Contributor

Please resolve conflicts.

image

@github-actions github-actions bot removed the core SeaTunnel core module label Nov 27, 2025
@github-actions github-actions bot added the core SeaTunnel core module label Nov 27, 2025
@dyp12
Copy link
Contributor Author

dyp12 commented Nov 28, 2025

CI failed, please check

ci always fail,Could not find stored procedure 'master..xp_sqljdbc_xa_init_e

@zhangshenghang
Copy link
Member

  • Pull Request Labeler / Build (pull_request_target)

Retry the incorrect CI

@dyp12
Copy link
Contributor Author

dyp12 commented Nov 29, 2025

CI failed, please check

ci pass

@dyp12
Copy link
Contributor Author

dyp12 commented Nov 29, 2025

  • Pull Request Labeler / Build (pull_request_target)

Retry the incorrect CI

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants