Fix set OnDuplicateKeyColumnsSegment on PostgreSQLInsertStatement #34425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @shijie-328931589, can you update release note? Besides, you need add an sql parser test for this change. |
strongduanmu
requested changes
Jan 22, 2025
| @@ -34,7 +34,7 @@ public final class PostgreSQLInsertStatement extends InsertStatement implements | |||
|
|
|||
| private WithSegment withSegment; | |||
|
|
|||
| private OnDuplicateKeyColumnsSegment onDuplicateKeyColumnsSegment; | |||
| private OnDuplicateKeyColumnsSegment onDuplicateKeyColumns; | |||
There was a problem hiding this comment.
Can you check openGauss insert statement? Since they are same database dialect.
There was a problem hiding this comment.
yes, they have the same problem
| @@ -45,7 +45,7 @@ public Optional<WithSegment> getWithSegment() { | |||
|
|
|||
| @Override | |||
| public Optional<OnDuplicateKeyColumnsSegment> getOnDuplicateKeyColumns() { | |||
| return Optional.ofNullable(onDuplicateKeyColumnsSegment); | |||
| return Optional.ofNullable(onDuplicateKeyColumns); | |||
There was a problem hiding this comment.
Besides, you need add sql parser test for this change.
strongduanmu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 34424
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.