Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed locals in elasticsearch #32

Merged
merged 4 commits into from
Mar 11, 2024
Merged

fixed locals in elasticsearch #32

merged 4 commits into from
Mar 11, 2024

Conversation

mayank0202
Copy link
Contributor

@mayank0202 mayank0202 commented Mar 7, 2024 •
edited
Loading

Terraform apply and plan both works perfectly

@wu-sheng wu-sheng requested a review from kezhenxu94 March 7, 2024 12:27
kezhenxu94
kezhenxu94 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kezhenxu94
Copy link
Member

Please update the doc

@mayank0202
Copy link
Contributor Author

@kezhenxu94 whats the command for updating docs? i know terraform docs updates the readme i guess

@kezhenxu94
Copy link
Member

@kezhenxu94 whats the command for updating docs? i know terraform docs updates the readme i guess

use terraform-doc

terraform-docs markdown table --output-file configurations.md --output-mode inject aws

@mayank0202
Copy link
Contributor Author

@kezhenxu94 Done

@mayank0202
Copy link
Contributor Author

@kezhenxu94 Why checks are failing ? any idea?

@kezhenxu94
Copy link
Member

@kezhenxu94 Why checks are failing ? any idea?

Checking out the codes failed, I believe this is an incident of GitHub itself,

@kezhenxu94 kezhenxu94 merged commit 9108676 into apache:main Mar 11, 2024
3 checks passed
@wu-sheng wu-sheng added this to the 0.1.0 milestone Mar 11, 2024
@mayank0202 mayank0202 deleted the refactor-elasticsearch branch March 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mayank0202 @kezhenxu94 @wu-sheng