Bug in Bar plot labels for 0 values

[janaperedni]

Screenshot

Description

Hi! I think I found a bug in bar plot visualization for 0 values. So as you can see from my screenshots, when you navigate to a certain bar it displays the dimensions' value, but it doesn't for the ones with 0 value although it exists in the underlying dataset. I couldn't find how to enable it therefore I consider it a bug.

Design input

No design input needed

[dosubot]

Hello, @janaperedni! I'm here to help you with any bugs, questions, or contributions. Let's take a look at the issue you've encountered.

The issue you're experiencing with bar plot labels not displaying for zero values might be related to the configuration setting showBarValue. If this property is set to true, labels for bar values, including zero values, should be displayed. You might want to check if this setting is enabled in your configuration ^[1].

Additionally, the drawBarValues function, which is responsible for rendering labels, does not have an explicit condition to prevent labels for zero values. However, if the number formatter used in this function suppresses zero values, that could be the reason for the labels not appearing ^[2].

If the issue persists, you may need to investigate further into the number formatting logic or any CSS styles that might affect the visibility of these labels.

To continue talking to Dosu, mention @dosu.

[janaperedni]

@dosu , showBarValue is enabled to True

ALso the label I am talking about is a dimension label. The x-axis label works for zeros as well, but the dimension one is off

[sfirke]

What version of Superset is this happening in?

[dosubot]

The drawBarValues function appends text elements for each bar to display the values, and there is no explicit condition that prevents dimension labels from being displayed for zero values ^[1]. However, the visibility of dimension labels might be affected by other factors, such as CSS styles or the number formatter used in the function.

If the showBarValue is set to true and the issue persists, you might want to check the CSS styles applied to the labels to ensure they are not hidden or styled in a way that makes them invisible. Additionally, verify the number formatter configuration to ensure it is not suppressing zero values.

To continue talking to Dosu, mention @dosu.

[rusackas]

As far as I can tell, this is working fine now, but if I'm mistaken, let me know and we can reopen!