Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant Design 5: Upgrade Button component #31566

Closed
geido opened this issue Dec 19, 2024 · 3 comments · Fixed by #31623
Closed

Ant Design 5: Upgrade Button component #31566

geido opened this issue Dec 19, 2024 · 3 comments · Fixed by #31623
Assignees
Labels
frontend:refactor:antd5 preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.

Comments

@geido
Copy link
Member

geido commented Dec 19, 2024

Please refer to SIP-139 #29268.

The Button component should be upgraded to Ant Design version 5.

Similar work has been completed here.

When upgrading the component to Ant Design 5, please ensure to include:

  • Proper RTL test coverage if not present yet.
  • A Storybook file (if not present) or all necessary changes.
  • Include all relevant component options in the Storybook.
  • Clean up unnecessary custom styles.

When opening a PR:

  • Name your PR refactor({Component}): Upgrade {component} to Ant Design 5
  • Add screenshots of BEFORE/AFTER in your PR.
  • Update the project tracker when your PR is merged.
  • Make sure you or a committer has labeled your PR with frontend:refactor:antd5.
@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. labels Dec 19, 2024
@alexandrusoare
Copy link
Contributor

Hey @geido, I am interested in taking this one so that I can finish my work on the modal as well: #31420

@geido
Copy link
Member Author

geido commented Dec 19, 2024

Hey @geido, I am interested in taking this one so that I can finish my work on the modal as well: #31420

Ok I see that we need the button upgrade to clean up the buttons of the Modal. Can we merge the Modal first and then finish it up in this button PR?

@alexandrusoare
Copy link
Contributor

Sure, sounds good 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend:refactor:antd5 preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@alexandrusoare @geido and others