Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to update Saved Queries #31369

Open
2 of 3 tasks
yousoph opened this issue Dec 10, 2024 · 6 comments · May be fixed by #31639
Open
2 of 3 tasks

Unable to update Saved Queries #31369

yousoph opened this issue Dec 10, 2024 · 6 comments · May be fixed by #31639
Assignees
@DamianPendrak
Labels
preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached. sqllab:saved_queries

Comments

@yousoph
Copy link
Member

yousoph commented Dec 10, 2024

Bug description

Description

Users can save queries from the SQL Lab for future reference or reusability. However, accessing the saved queries from the list creates a new saved query upon saving the changes rather than updating the existing saved query

How to reproduce the bug

  1. Run a query in the SQL Lab.
  2. Save the query.
  3. Close the query tab.
  4. Access the saved query from the SQL > Saved Queries menu.
  5. Perform some changes and save.

Expected results

The query will have an update or save as new option. User should see a Save As modal that allows them to update their current query (see screenshots below)

Actual results

The query can only be saved as a new saved query.

Other Details

Query can be updated as long as the query tab is not closed. Any tabs that are opened later will show the incorrect modal without the Save as New / Update options.

Screenshots/recordings

What the user currently sees when trying to save a query:
image

Save modal should look like the below when editing your existing query:
image

Superset version

master / latest-dev

Python version

3.9

Node version

16

Browser

Chrome

Additional context

No response

Checklist

  • I have searched Superset docs and Slack and didn't find a solution to my problem.
  • I have searched the GitHub issue tracker and didn't find a similar bug report.
  • I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
@peacelovingng
Copy link

When you try to save a new query initially, it displays the first screenshot. When you save and make changes, you see the second screenshot.

@geido
Copy link
Member

geido commented Dec 10, 2024

🎉 Preset Bounty Available: $150 USD 🎉

To claim this bounty, please carefully follow the steps below.

📋 Steps to Participate

  1. Review Guidelines:
    Read through the Preset Bounty Program Contribution Guide for complete details on bounty requirements.

  2. Show Your Interest:
    Complete the Preset Bounty Program Survey and comment this issue to express your interest.

  3. Join the Slack Channel:
    After completing the survey, you’ll receive an invitation to the dedicated Apache Superset Slack channel.

  4. Get Assigned:
    To officially start, ensure a Bounty Program Manager has assigned you to this issue.

  5. Submit Your Solution:
    When ready, submit your solution with the Fixes #{issue_number} notation in your Pull Request description.

  6. Claim Your Bounty:
    Sign up at GitPay.me and submit your solution via: https://gitpay.me/#/task/1012

💡 Additional Notes

  • Only developers assigned by a Bounty Program Manager should start working on this issue to win the bounty.
  • Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.

Good luck, and happy coding! 🎉

@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. labels Dec 10, 2024
@DamianPendrak
Copy link
Contributor

I'd like to work on this issue

@Niharika0104
Copy link

Niharika0104 commented Dec 13, 2024 •
edited
Loading

I'd like to work on this issue @geido

@geido
Copy link
Member

geido commented Dec 13, 2024 •
edited
Loading

I'd like to work on this issue @geido

This issue is already assigned for now

@syedbarimanjan
Copy link

@geido can I work on this issue as it has been more than 2 weeks and no response from the assigned contributer.

@DamianPendrak DamianPendrak linked a pull request Dec 28, 2024 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DamianPendrak DamianPendrak

Labels
preset:bounty:bug Bugs that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached. sqllab:saved_queries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sqllab): unable to update saved queries DamianPendrak/superset
7 participants
@DamianPendrak @yousoph @peacelovingng @geido @syedbarimanjan @Niharika0104 and others