Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.45%. Comparing base (76d897e) to head (cd8bc60).
Report is 1471 commits behind head on master.

@@             Coverage Diff             @@
##           master   #32294       +/-   ##
===========================================
+ Coverage   60.48%   83.45%   +22.96%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39098    -37138     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32630    -13484     
+ Misses      28017     6468    -21549     
+ Partials     2105        0     -2105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I have no problem with the timeouts (we might need more of them, honestly!) but I'm wondering if the jsonrepair addition might have any unintended side effects. Does that library properly escape the single quote and solve the problem without changing the text? I'm worried there may be any number of strings throughout the codebase with apostrophes, and hope we can handle them properly rather than work around them.

Does that library properly escape the single quote and solve the problem without changing the text?

The library fixes the input string in best effort approach and at least returns JSON-compliant object.

I'm worried there may be any number of strings throughout the codebase with apostrophes, and hope we can handle them properly rather than work around them.

This is going to be tedious so that's why I added a failsafe with jsonrepair. What do you think of initially parse input data with native JSON.parse and if failed, fixes the input string and reparse again?

export default function getBootstrapData(): BootstrapData {
  const appContainer = document.getElementById('app');
  const dataBootstrapString = appContainer?.getAttribute('data-bootstrap');
  if (!dataBootstrapString) {
    return DEFAULT_BOOTSTRAP_DATA
  }

  try {
    return JSON.parse(dataBootstrapString) 
  } catch (error) {
    return JSON.parse(jsonrepair(dataBootstrapString))
  }
}

What do you think of initially parse input data with native JSON.parse and if failed, fixes the input string and reparse again?

I think that's a good idea... it seems like it would de-risk jsonrepair doing anything unexpected/unintended.

Optionally, you could go the extra mile and try the jsonrepair and throw an error about malformed json if both methods fail.