fix: ODPS data source table preview failed #32301 #32310
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Undefined partition variable in ODPS preview logic ▹ view | ✅ |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/databases/utils.py | ✅ |
| superset/daos/database.py | ✅ |
| superset/sql/parse.py | ✅ |
| superset/models/core.py | ✅ |
| superset/databases/api.py | ✅ |
| superset/db_engine_specs/base.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
|
Thank you for the PR! I left a few comments and also you'll need to run added changes against established pre-commit hooks here. |
superset/daos/database.py
Outdated
| access_id = match.group('username') | ||
| project = match.group('project') | ||
| endpoint = match.group('endpoint') | ||
| access_key = passwd |
There was a problem hiding this comment.
Re-assign DB's password to a 3rd variable seems odd here.
There was a problem hiding this comment.
Access_key=passwd, I assigned passwd to Access_key, so that when using ODPS to build connections later, I have a visual experience of AK and Secret
There was a problem hiding this comment.
Are there any benefits aside of readability? I'm not holding strong opinion on this but feels like this assignment is a bit excessive.
sadpandajoe
added
the
review:checkpoint
sadpandajoe
removed
the
review:checkpoint
|
approving a CI run, and adding a couple more reviewers for good measure :) |
zhutong6688
changed the title
zhutong6688
changed the title
|
Please approve and agree a CI run，I have made the necessary corrections based on the error message |
|
Some of the data source test classes did not pass. Let me take a look at the problem again and see if there are any issues with the test classes being written |
|
Please approve and agree a CI run again, Thanks a lot |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32310 +/- ##
===========================================
+ Coverage 60.48% 76.24% +15.75%
===========================================
Files 1931 546 -1385
Lines 76236 39138 -37098
Branches 8568 0 -8568
===========================================
- Hits 46114 29840 -16274
+ Misses 28017 9298 -18719
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Could you please help me run a CI again so that I can see if there are any other check errors，Thanks again |
SUMMARY
I fixed an error when using sqllab to preview data after configuring the odps data source in superset, and added partition restrictions for previewing SQL
fixes: #32301
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
This is a preview of the odps table data before the repair：
This is a preview of the repaired ODPS table data：
In addition, when using other data sources, there is no problem with testing and it does not affect other data sources
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION