Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] nn.Conv3D groups not working correctly #17062

Open
DeclK opened this issue Jun 4, 2024 · 0 comments
Open

[Bug] nn.Conv3D groups not working correctly #17062

DeclK opened this issue Jun 4, 2024 · 0 comments
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug

Comments

@DeclK
Copy link

DeclK commented Jun 4, 2024

nn.Conv3D is bugged

if isinstance(self.in_channels, int):
in_channels = int(self.in_channels / self.groups)
else:
in_channels = tir.floordiv(self.in_channels, self.groups)
# Expand kernel size if given an integer.
if isinstance(kernel_size, int):
self.kernel_size = [kernel_size] * 3
else:
self.kernel_size = kernel_size
kernel_shape = [self.out_channels, self.in_channels] + list(self.kernel_size)

line 325 should use in_channels instead of self.in_channels to make groups work. Otherwise in_channels calculated at line 317 would not be effectively used in weight parameters.

@DeclK DeclK added needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage PRs or issues that need to be investigated by maintainers to find the right assignees to address it type: bug
Projects
None yet
Development

No branches or pull requests

1 participant