Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dependence on apisix-base #87

Open
zll600 opened this issue Feb 23, 2024 · 0 comments
Open

refactor: remove dependence on apisix-base #87

zll600 opened this issue Feb 23, 2024 · 0 comments

Comments

@zll600
Copy link
Contributor

zll600 commented Feb 23, 2024

The dependency should be apisix-base depends on apisix-nginx-module.

build-apisix-base.sh --> apisix-nginx-module

So we should not use build-apisix-base.sh in CI

wget https://raw.githubusercontent.com/api7/apisix-build-tools/master/build-apisix-base.sh

A better way is to refer to CI of lua-resty-core to add a new script only for apisix-nginx-module. ref: https://github.com/openresty/lua-resty-core/blob/dc3fdd91b1abc2aac6706c9117a99cd2e00e6133/.travis.yml#L65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant