Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Fix for Deprecated issue - preg_quote(): Passing null to parameter #469

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #462

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #469 (d7d9d63) into 2.x (b282a8f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x     #469   +/-   ##
=========================================
  Coverage     49.24%   49.24%           
  Complexity     1997     1997           
=========================================
  Files           200      200           
  Lines          7399     7399           
=========================================
  Hits           3644     3644           
  Misses         3755     3755           

@kedarkhaire kedarkhaire added this to the 2.1.2 milestone Nov 15, 2023
@kedarkhaire kedarkhaire marked this pull request as ready for review November 15, 2023 13:00
@kedarkhaire kedarkhaire changed the title Added patch for Deprecated issue Test Fix for Deprecated issue - preg_quote(): Passing null to parameter Nov 15, 2023
@kedarkhaire
Copy link
Collaborator Author

We do not have this error on sites, we get this on test cases execution as a Deprecated notice.
It is a Drupal core level issue also a patch to solve it is provided in it.

Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit c13ddd1 into apigee:2.x Nov 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation notice : preg_quote(): Passing null to parameter #1 ($str) of type string is deprecated
2 participants