Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date construction from String with ms fails #123

Open
theganyo opened this issue Aug 5, 2015 · 3 comments
Open

Date construction from String with ms fails #123

theganyo opened this issue Aug 5, 2015 · 3 comments

Comments

@theganyo
Copy link
Member

theganyo commented Aug 5, 2015

This script:

console.log(new Date('March 31, 2013 23:59:59.9999'))

executes on Node.js and emits the following:

Sun Mar 31 2013 23:59:59 GMT-0700 (PDT)

but on Trireme it fails to create the Date and emits:

Invalid Date

Note: This appears to be an issue with processing the ms, as this works on Trireme:

console.log(new Date('March 31, 2013 23:59:59'))
@theganyo theganyo changed the title Date construction fails Date construction with ms fails Aug 5, 2015
@theganyo theganyo changed the title Date construction with ms fails Date construction from String with ms fails Aug 5, 2015
@theganyo
Copy link
Member Author

theganyo commented Aug 5, 2015

Note: This currently causes tests to fail for Volos on Trireme... but it's just a test failure, not a functional failure.

@gbrail
Copy link
Contributor

gbrail commented Aug 6, 2015

Opened issue 224 in Rhino, because that's where stuff like this can be fixed.

@theganyo
Copy link
Member Author

theganyo commented Aug 6, 2015

Aha. Well, that's why I couldn't find any related code in Trireme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants