Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"toc" stylesheet links are broken #62

Open
henning-schild opened this issue Nov 7, 2020 · 6 comments
Open

"toc" stylesheet links are broken #62

henning-schild opened this issue Nov 7, 2020 · 6 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@henning-schild
Copy link

Generating html from a CHANGELOG i found that old versions of "ronn" generate a Table of Contents with links that actually take you to the release you clicked. With "ronn-ng" that is not the case anymore. Also tried most recent 0.9.1 in debian11.

Steps to reproduce:

git clone https://github.com/apjanke/ronn-ng
cd ronn-ng
docker run -v $(pwd):/this/:rw --rm -t -i debian:bullseye
apt-get update -qq; apt-get install ronn -y
cd /this
ronn -h CHANGES --style=dark,toc --pipe > CHANGES.html

Browse to <path-to-clone>/CHANGES.html and click those links.

@apjanke
Copy link
Owner

apjanke commented Dec 22, 2020

Bummer. That sounds like a regression to me. Scheduling this for addressing in 0.11.0 with High priority.

@apjanke apjanke added this to the 0.11.0 milestone Dec 22, 2020
@apjanke apjanke added the bug Something isn't working label Dec 22, 2020
@apjanke apjanke self-assigned this Dec 22, 2020
@henning-schild
Copy link
Author

Any news on this one?

@apjanke
Copy link
Owner

apjanke commented Oct 27, 2021

Hi, henning-schild! Sorry: I'm afraid I've been swamped at the day job for quite some time now. I'll see if I can find some time this weekend to work on it.

@henning-schild
Copy link
Author

ronn (0.9.1-2) installed from "debian:bullseye" does not seem to have that issue anymore, did not check whether debian applied patches or how it got fixed, might also just be the firefox i use

The issue is gone, no clue why.

@apjanke
Copy link
Owner

apjanke commented May 21, 2022

Thanks for the report, @henning-schild!

I'm reopening this bug, because I suspect that this is a Ronn-NG bug that was fixed by a downstream patch by Debian that I should upstream here; I'm just not good enough at reading the Debian package files to figure out if this is the case. Feel free to unsubscribe from this bug report, or if that's not possible, let me know, and I'll open a separate bug for this.

@apjanke apjanke reopened this May 21, 2022
@henning-schild
Copy link
Author

Sure thing. I will keep reading for now.

A good way of looking at it is to look at the package from debian.

find it in their feed and you end up here https://packages.debian.org/bullseye/ronn

from there you will find the "orig.tar.gz" which contains what comes from "upstream" ... so probably really just whatever you have here under that tag
http://deb.debian.org/debian/pool/main/r/ruby-ronn/ruby-ronn_0.9.1.orig.tar.gz

then debian has its own overlay .. the "debian.tar.gz", which contains metadata, build instruction and patches

if you look at http://deb.debian.org/debian/pool/main/r/ruby-ronn/ruby-ronn_0.9.1-2.debian.tar.xz you will find patches that debian applies

if you want to dig even deeper you can look at their changelog, all the patches they apply probably have a debian bug somehow attached to them

and you might find that "downstream" debian decided to apply a patch which would have been valuable for "upstream" ... you and all ronn-ng users.

I think i started this of with pure "upstream", no clue why debian decided to not get in touch ... or maybe they did and failed because the link to this very issue was missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: High priority
Development

No branches or pull requests

2 participants