Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner dispatching onto StaticArrays #39

Open
apkille opened this issue Jan 25, 2025 · 0 comments
Open

Cleaner dispatching onto StaticArrays #39

apkille opened this issue Jan 25, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@apkille
Copy link
Owner

apkille commented Jan 25, 2025

As discussed in the docs, creating Gabs types that wrap around static arrays requires the user to specify the array size. This isn't really necessary, as the array size is implicit in the choice of symplectic basis. So, there should be a more straightforward way of doing this from the high-level interface. Rather than, for example,

vacuumstate(SVector{4}, SMatrix{4,4}, QuadBlockBasis(2)) -> GaussianState{QuadBlockBasis{Int64}, SVector{4, Float64}, SMatrix{4, 4, Float64, 16}}

a user should be able to simply write

vacuumstate(SVector, SMatrix, QuadBlockBasis(2)) -> GaussianState{QuadBlockBasis{Int64}, SVector{4, Float64}, SMatrix{4, 4, Float64, 16}}

where manually entering array dimension information is not required.

@apkille apkille added enhancement New feature or request good first issue Good for newcomers labels Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant