Skip to content

move integration-test monorepo into root monorepo#421

Merged
phryneas merged 5 commits intonextfrom
pr/unify
Jan 24, 2025
Merged

move integration-test monorepo into root monorepo#421
phryneas merged 5 commits intonextfrom
pr/unify

Conversation

@phryneas
Copy link
Copy Markdown
Member

@phryneas phryneas commented Jan 23, 2025

Let's see if this is less painful

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 3f28c35

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
apollo__client-integration-react-router ✅ Ready (Inspect) Visit Preview Jan 23, 2025 4:59pm
apollo__client-integration-tanstack-start ✅ Ready (Inspect) Visit Preview Jan 23, 2025 4:59pm

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Jan 23, 2025

npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/client-react-streaming@421
npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/experimental-nextjs-app-support@421
npm i https://pkg.pr.new/apollographql/apollo-client-nextjs/@apollo/client-integration-react-router@421

commit: 3f28c35

@relativeci
Copy link
Copy Markdown

relativeci Bot commented Jan 23, 2025

#422 Bundle Size — 1.33MiB (+6.6%).

3f28c35(current) vs 5293db1 main#409(baseline)

Warning

Bundle contains 1 duplicate package – View duplicate packages

Warning

Bundle introduced one new package: process – View changed packages

Bundle metrics  Change 8 changes Regression 1 regression Improvement 2 improvements
                 Current
#422
     Baseline
#409
Regression  Initial JS 1.05MiB(+5.68%) 1016.91KiB
No change  Initial CSS 70B 70B
Change  Cache Invalidation 81.12% 0.08%
Change  Chunks 37(+8.82%) 34
Change  Assets 63(+6.78%) 59
Change  Modules 676(+6.29%) 636
Improvement  Duplicate Modules 98(-7.55%) 106
Change  Duplicate Code 4.33%(-7.87%) 4.7%
Improvement  Packages 25(-3.85%) 26
No change  Duplicate Packages 1 1
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
#422
     Baseline
#409
Regression  JS 1.32MiB (+6.55%) 1.24MiB
Regression  Other 10.28KiB (+13.06%) 9.09KiB
No change  CSS 70B 70B

Bundle analysis reportBranch pr/unifyProject dashboard


Generated by RelativeCIDocumentationReport issue

@phryneas
Copy link
Copy Markdown
Member Author

This seems like a good way forward. We had the nested monorepos only because we were ending up with multiple React versions because we needed those for different integration tests - but we don't really need those anymore (it's a bit sad to see the experimental build go but meh I guess)

I think this works out a lot less frustrating in the long run

@phryneas phryneas marked this pull request as ready for review January 24, 2025 09:09
@phryneas phryneas requested a review from a team as a code owner January 24, 2025 09:09
@phryneas phryneas merged commit 543ec64 into next Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant