Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The section get-started should recommend Vite instead of CRA. #11305

Closed
gento-ogane opened this issue Oct 19, 2023 · 7 comments · Fixed by #11352
Closed

The section get-started should recommend Vite instead of CRA. #11305

gento-ogane opened this issue Oct 19, 2023 · 7 comments · Fixed by #11352

Comments

@gento-ogane
Copy link
Contributor

The section get-started explains how to build react app with CRA, but CRA is entrying maintenance mode.
Official React doc also doesn't describe about CRA anymore, and now refers Vite.

If this proposal is approval, I will try to create PR which updates descriptions about CRA to Vite in get-started.

@bignimbus bignimbus added 📝 documentation 🏓 awaiting-team-response requires input from the apollo team labels Oct 20, 2023
@bignimbus
Copy link
Contributor

Hi @gento-ogane, I've added this request to an upcoming team meeting to talk it through. Thanks for this suggestion, it seems reasonable 🙏🏻

@bignimbus
Copy link
Contributor

@gento-ogane we would be eager to review a PR to replace CRA with Vite in our docs. Please let us know how we can be helpful, thanks for volunteering to take this on! 🚀

@bignimbus bignimbus added 😍 pull-requests-welcome and removed 🏓 awaiting-team-response requires input from the apollo team labels Oct 24, 2023
@gento-ogane
Copy link
Contributor Author

@bignimbus
Thank you for your response!
I will create PR. If I'm in trouble, I'll ask questions!!

@gento-ogane
Copy link
Contributor Author

Here is the working branch.
https://github.com/gento-ogane/apollo-client/tree/11305-update-doc-replace-to-vite

gento-ogane added a commit to gento-ogane/apollo-client that referenced this issue Nov 2, 2023
gento-ogane added a commit to gento-ogane/apollo-client that referenced this issue Nov 9, 2023
gento-ogane added a commit to gento-ogane/apollo-client that referenced this issue Nov 9, 2023
gento-ogane added a commit to gento-ogane/apollo-client that referenced this issue Nov 9, 2023
gento-ogane added a commit to gento-ogane/apollo-client that referenced this issue Nov 9, 2023
gento-ogane added a commit to gento-ogane/apollo-client that referenced this issue Nov 9, 2023
gento-ogane added a commit to gento-ogane/apollo-client that referenced this issue Nov 9, 2023
gento-ogane added a commit to gento-ogane/apollo-client that referenced this issue Nov 9, 2023
@jerelmiller jerelmiller linked a pull request Nov 9, 2023 that will close this issue
3 tasks
@gento-ogane
Copy link
Contributor Author

gento-ogane commented Nov 14, 2023

@bignimbus
I created Pull Request!!
Please review this PR.

Copy link
Contributor

Do you have any feedback for the maintainers? Please tell us by taking a one-minute survey. Your responses will help us understand Apollo Client usage and allow us to serve you better.

Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
For general questions, we recommend using StackOverflow or our discord server.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants