Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to provide custom ObjectCache for InMemoryCache #154

Closed
morrys opened this issue Jul 11, 2019 · 4 comments
Closed

Allow to provide custom ObjectCache for InMemoryCache #154

morrys opened this issue Jul 11, 2019 · 4 comments

Comments

@morrys
Copy link

morrys commented Jul 11, 2019

Hi all,
I wanted to ask if it was possible to add customData to the parameters provided by InMemoryCacheConfig. This to best integrate the library https://www.npmjs.com/package/@wora/apollo-cache

I think it is a valid alternative to apollo-cache-persist and your opinion is welcome.

Thank you,
Lorenzo

@wtrocki
Copy link

wtrocki commented Jul 17, 2019

Is there a reason why this cannot be done in apollo-cache-persist?
Apollo-Cache-Persist library is fully supported by the community and we are really looking for feedback on how this library can move forward to support more advanced cases like filtering etc.

@morrys
Copy link
Author

morrys commented Jul 17, 2019

I opened this issue to evaluate with the people who maintain apollo projects what is the best way to evolve these features and how to evolve the @wora/cache-persist library that I use as persistence in other contexts.

@wtrocki
Copy link

wtrocki commented Jul 17, 2019

I would personally love to see PR to the apollo-client repository so I can help you with these goals and comment on the code. Apollo client 3.0 will come with cache invalidation feature that may change some internal implementations. It is nice to drop some potentially breaking changes now for the community to comment on. Lack of cache persistence in InMemoryCache was an always big problem.

I think it is a valid alternative to apollo-cache-persist and your opinion is welcome.

I personally would love to have a collaboration on apollo-cache-persist package rather than creating alternatives. This is where the most community is now and there are couple issues that we can resolve to make it nice. Apollo-Cache-Persist can be used now to achieve offline capabilities for queries and many developers using it this way.

@jerelmiller
Copy link
Member

Hey all 👋. As @benjamn mentioned in this comment try using apollo3-cache-persist which works with AC3.

I'm doing a bit of housekeeping to try and cleanup some older PRs and issues. Since we've closed #5601, I'm going to close this issue as well. Feel free to re-open the issue or create a new discussion if need be. Thanks!

@jerelmiller jerelmiller closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants