-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphql-go Federation support #74
Comments
It is a good idea, I need Federation support |
We're going to prep a PR to add Federation enabling changes in |
POC is available at dariuszkuc/[email protected]. Example implementation of the testing schema used in this repo: https://github.com/dariuszkuc/graphql/tree/federation/examples/federation (ftv1 tracing is not supported, all other tests are 🟢)
Once above PRs are merged we can create and publish separate |
While we wait for feedback (and 🤞 our |
Example `graphql-go` integration that is using https://github.com/dariuszkuc/graphql/releases/tag/v0.9.0-federation NOTE: this is a temporary solution while we are waiting for `graphql-go` PRs to get merged ([651](graphql-go/graphql#651), [652](graphql-go/graphql#652) and [653](graphql-go/graphql#653)). Resolves: apollographql#74
Example `graphql-go` integration that is using https://github.com/dariuszkuc/graphql/releases/tag/v0.9.0-federation NOTE: this is a temporary solution while we are waiting for `graphql-go` PRs to get merged ([651](graphql-go/graphql#651), [652](graphql-go/graphql#652) and [653](graphql-go/graphql#653)). Resolves: #74
Re-opening this issue to use as our tracking issue for getting @dariuszkuc's awesome |
There is an interesting discussion about adding Federation support to
graphql-go
here: graphql-go/graphql#492graphql-go
is intended to be more of agraphql-js
clone, which means Federation support doesn't necessarily belong in the library itself, but it looks like there are API changes that could be made tographql-go
to make it easier to use with Federation. The above linked to issue dives into this a bit (graphql-go/graphql#492 (comment)), but we'll need to validate this and see if any other changes are needed (see also graphql-go/graphql#541). If we can help get these changes in place, we can then think about potentially creating a Go based Federation helper library, like we've done with@apollo/subgraph
(JS/Node) andfederation-jvm
(Java/JVM).The text was updated successfully, but these errors were encountered: