Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql-go Federation support #74

Open
hwillson opened this issue Feb 21, 2022 · 5 comments · Fixed by #255
Open

graphql-go Federation support #74

hwillson opened this issue Feb 21, 2022 · 5 comments · Fixed by #255
Assignees

Comments

@hwillson
Copy link
Member

There is an interesting discussion about adding Federation support to graphql-go here: graphql-go/graphql#492

graphql-go is intended to be more of a graphql-js clone, which means Federation support doesn't necessarily belong in the library itself, but it looks like there are API changes that could be made to graphql-go to make it easier to use with Federation. The above linked to issue dives into this a bit (graphql-go/graphql#492 (comment)), but we'll need to validate this and see if any other changes are needed (see also graphql-go/graphql#541). If we can help get these changes in place, we can then think about potentially creating a Go based Federation helper library, like we've done with @apollo/subgraph (JS/Node) and federation-jvm (Java/JVM).

@hwillson hwillson self-assigned this Feb 21, 2022
@hwillson hwillson added the help wanted Extra attention is needed label Feb 21, 2022
@codebdy
Copy link

codebdy commented May 5, 2022

It is a good idea, I need Federation support

@hwillson
Copy link
Member Author

hwillson commented Aug 4, 2022

We're going to prep a PR to add Federation enabling changes in graphql-go.

@hwillson hwillson assigned dariuszkuc and unassigned hwillson Aug 9, 2022
@dariuszkuc
Copy link
Member

POC is available at dariuszkuc/[email protected].

Example implementation of the testing schema used in this repo: https://github.com/dariuszkuc/graphql/tree/federation/examples/federation (ftv1 tracing is not supported, all other tests are 🟢)

graphql-go/graphql PRs:

Once above PRs are merged we can create and publish separate federation module.

@hwillson
Copy link
Member Author

While we wait for feedback (and 🤞 our graphql-go PR's to be merged), we're going to go ahead and add graphql-go tests to this repo, pointing to the above fork for now.

dariuszkuc added a commit to dariuszkuc/apollo-federation-subgraph-compatibility that referenced this issue Oct 31, 2022
Example `graphql-go` integration that is using https://github.com/dariuszkuc/graphql/releases/tag/v0.9.0-federation

NOTE: this is a temporary solution while we are waiting for `graphql-go` PRs to get merged ([651](graphql-go/graphql#651), [652](graphql-go/graphql#652) and [653](graphql-go/graphql#653)).

Resolves: apollographql#74
dariuszkuc added a commit that referenced this issue Nov 1, 2022
Example `graphql-go` integration that is using https://github.com/dariuszkuc/graphql/releases/tag/v0.9.0-federation

NOTE: this is a temporary solution while we are waiting for `graphql-go` PRs to get merged ([651](graphql-go/graphql#651), [652](graphql-go/graphql#652) and [653](graphql-go/graphql#653)).

Resolves: #74
@hwillson
Copy link
Member Author

hwillson commented Nov 9, 2022

Re-opening this issue to use as our tracking issue for getting @dariuszkuc's awesome graphql-go + Federation work hopefully merged into the project.

@hwillson hwillson reopened this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants