ci: Codegen test scripts should halt job on failure (#825)

calvincestari · gh-action-runner · commit bd34ff963124 · 2025-11-05T23:43:01.000Z
diff --git a/Tests/TestCodeGenConfigurations/CodegenXCFramework/test-project.sh b/Tests/TestCodeGenConfigurations/CodegenXCFramework/test-project.sh
@@ -5,6 +5,6 @@ set -o pipefail  # Fail if any command in a pipeline fails
 # Clean up previous build artifacts
 rm -rf ./build
 
-xcodebuild archive -configuration Release -project "CodegenXCFramework.xcodeproj" -scheme "CodegenXCFramework" -destination 'generic/platform=macOS' -archivePath "./build/macOS.xcarchive" SKIP_INSTALL=NO BUILD_LIBRARY_FOR_DISTRIBUTION=NO | xcbeautify
+xcodebuild archive -configuration Release -project "CodegenXCFramework.xcodeproj" -scheme "CodegenXCFramework" -destination 'generic/platform=macOS' -archivePath "./build/macOS.xcarchive" SKIP_INSTALL=NO BUILD_LIBRARY_FOR_DISTRIBUTION=NO | xcbeautify --is-ci
 
-xcodebuild -create-xcframework -allow-internal-distribution -output ./build/CodegenXCFramework.xcframework -framework ./build/macOS.xcarchive/Products/Library/Frameworks/CodegenXCFramework.framework | xcbeautify
+xcodebuild -create-xcframework -allow-internal-distribution -output ./build/CodegenXCFramework.xcframework -framework ./build/macOS.xcarchive/Products/Library/Frameworks/CodegenXCFramework.framework | xcbeautify --is-ci
diff --git a/Tests/TestCodeGenConfigurations/EmbeddedInTarget-InSchemaModule/test-project.sh b/Tests/TestCodeGenConfigurations/EmbeddedInTarget-InSchemaModule/test-project.sh
@@ -1,3 +1,4 @@
 #!/bin/bash
+set -eo pipefail
 
 swift test -Xswiftc -warnings-as-errors
diff --git a/Tests/TestCodeGenConfigurations/EmbeddedInTarget-RelativeAbsolute/test-project.sh b/Tests/TestCodeGenConfigurations/EmbeddedInTarget-RelativeAbsolute/test-project.sh
@@ -1,5 +1,5 @@
 #!/bin/bash
-set -e
+set -eo pipefail
 
 echo "Testing PackageOne.."
 cd PackageOne
diff --git a/Tests/TestCodeGenConfigurations/Other-CustomTarget/test-project.sh b/Tests/TestCodeGenConfigurations/Other-CustomTarget/test-project.sh
@@ -1,3 +1,4 @@
 #!/bin/bash
+set -eo pipefail
 
-set -o pipefail && xcodebuild test -scheme CustomTargetProject -destination platform=macOS -quiet | xcbeautify --is-ci
+xcodebuild test -scheme CustomTargetProject -destination platform=macOS -quiet | xcbeautify --is-ci
diff --git a/Tests/TestCodeGenConfigurations/SPMInXcodeProject/test-project.sh b/Tests/TestCodeGenConfigurations/SPMInXcodeProject/test-project.sh
@@ -1,3 +1,4 @@
 #!/bin/bash
+set -eo pipefail
 
-set -o pipefail && xcodebuild test -scheme SPMInXcodeProject -destination platform=macOS -quiet | xcbeautify --is-ci
+xcodebuild test -scheme SPMInXcodeProject -destination platform=macOS -quiet | xcbeautify --is-ci
diff --git a/Tests/TestCodeGenConfigurations/SwiftPackageManager/test-project.sh b/Tests/TestCodeGenConfigurations/SwiftPackageManager/test-project.sh
@@ -1,3 +1,4 @@
 #!/bin/bash
+set -eo pipefail
 
 swift test -Xswiftc -warnings-as-errors

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
`1`	`1`	`#!/bin/bash`
	`2`	`+set -eo pipefail`
`2`	`3`
`3`	`4`	`swift test -Xswiftc -warnings-as-errors`