This repository has been archived by the owner on Jul 10, 2019. It is now read-only.
Always return null #133
Open
Always return null #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiter
reviewed
Dec 21, 2017
| @@ -57,7 +57,7 @@ export const withClientState = ( | |||
| resolvers[(rootValue as any).__typename || type][ | |||
| info.resultKey || fieldName | |||
| ]; | |||
| if (resolve) return resolve(rootValue, args, context, info); | |||
| if (resolve) return resolve(rootValue, args, context, info) || null; | |||
There was a problem hiding this comment.
I would add a check for only undefined, because the resolver might return 0 or false by design.
There was a problem hiding this comment.
And what if it's an async resolver? A promise will always be truthy, even if it resolves to undefined.
|
Hey @peggyrayzis -- I think this PR is still needed (-- do you concur?), but @jamiter made some good points. Is this something you're coming back to? Or would you like someone to collaborate on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQL servers never return undefined, always null. We need to also return null from resolvers without a return value to avoid warnings in Apollo Client.