Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store recursive types in ungrammar #84

Open
lrlna opened this issue Sep 30, 2021 · 0 comments
Open

store recursive types in ungrammar #84

lrlna opened this issue Sep 30, 2021 · 0 comments
Assignees
Labels
apollo-parser bug Something isn't working

Comments

@lrlna
Copy link
Member

lrlna commented Sep 30, 2021

There are three instances in our ungrammar file that are meant to be recursive but are currently not: DirectiveLocations, UnionMemberTypes and ImplementsInterfaces. We should figure out the best way to use ungrammar to record this information.

Current DirectiveLocations ungrammar:

DirectiveLocations =
  DirectiveLocation*

Should encompass this in the future:

 DirectiveLocations
   '|'? DirectiveLocation
    | DirectiveLocations '|' DirectiveLocation

Current UnionMemberTypes ungrammar:

UnionMemberTypes =
  '=' '|'? NamedType*

Should encompass this:

 UnionMemberTypes =
   '=' '|'? NamedType
    | UnionMemberTypes '|' NamedType
// maybe using this:
UnionMemberTypes =
   `'=' '|'? (NamedType '|')* NamedType`
@lrlna lrlna added bug Something isn't working size/medium apollo-parser labels Sep 30, 2021
@lrlna lrlna self-assigned this Oct 18, 2021
@abernix abernix added 2021-11 and removed 2021-10 labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apollo-parser bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants