Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for clean git stage after npm install and before release. #75

Open
abernix opened this issue Mar 15, 2022 · 0 comments
Open

Check for clean git stage after npm install and before release. #75

abernix opened this issue Mar 15, 2022 · 0 comments

Comments

@abernix
Copy link
Member

abernix commented Mar 15, 2022

To ensure there aren't any package-lock.json changes that are going to crop up. Maybe we can just check if git status --porcelain is empty but if we want something more specific, we could check the status codes of git diff --exit-code.
dingxiangfei2009 pushed a commit to dingxiangfei2009/federation-rs that referenced this issue Jun 23, 2022
@BrynCooke @EverlastingBugstopper @cecton
Added CORS support (apollographql#75)
9417ded 
* Added CORS support
resolves apollographql#52

To support Apollo Studio we must allow cross-origin requests from https://studio.apollographql.com/

Users can disable this using the server section in the configuration yaml if they have security concerns.

* Apply suggestions from code review

Co-authored-by: Avery Harnish <[email protected]>
Co-authored-by: Cecile Tonglet <[email protected]>

Co-authored-by: bryn <[email protected]>
Co-authored-by: Avery Harnish <[email protected]>
Co-authored-by: Cecile Tonglet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abernix