Router 1.50.0 fails when compiled with release mode

[cosmincatalin]

We're building a custom Docker image containing version 1.50.0 of the router. When we build the image with mode --debug we can run the router inside the Docker image just fine. However, when building the image and using --release mode we cannot really run the router inside the Docker image, as we get the following errors:

docker run --rm -v $(pwd):/app --env-file $(pwd)/.env router -s /app/supergraph-schema.k8s.graphql -c /app/router.k8s.yaml --dev

{"timestamp":"2024-07-09T11:49:09.628735542Z","level":"INFO","message":"Apollo Router v1.50.0 // (c) Apollo Graph, Inc. // Licensed as ELv2 (https://go.apollo.dev/elv2)","target":"apollo_router::executable","resource":{}}
{"timestamp":"2024-07-09T11:49:09.630944500Z","level":"INFO","message":"Anonymous usage data is gathered to inform Apollo product development.  See https://go.apollo.dev/o/privacy for details.","target":"apollo_router::executable","resource":{}}
{"timestamp":"2024-07-09T11:49:09.641761459Z","level":"INFO","message":"Running with *development* mode settings which facilitate development experience (e.g., introspection enabled)","target":"apollo_router::configuration::expansion","resource":{}}
{"timestamp":"2024-07-09T11:49:09.667975084Z","level":"INFO","message":"Running with *development* mode settings which facilitate development experience (e.g., introspection enabled)","target":"apollo_router::configuration::expansion","resource":{}}
{"timestamp":"2024-07-09T11:49:09.672214334Z","level":"WARN","message":"telemetry.instrumentation.spans.mode is currently set to 'deprecated', either explicitly or via defaulting. Set telemetry.instrumentation.spans.mode explicitly in your router.yaml to 'spec_compliant' for log and span attributes that follow OpenTelemetry semantic conventions. This option will be defaulted to 'spec_compliant' in a future release and eventually removed altogether","target":"apollo_router::plugins::telemetry","resource":{}}
{"timestamp":"2024-07-09T11:49:09.792022376Z","level":"WARN","message":"an error happened in the worker runtime TypeError: Error parsing args at position 1: serde_v8 error: invalid type; expected: object, got: string\n\n","target":"router_bridge::worker","resource":{"service.version":"1.50.0","service.name":"unknown_service:router","process.executable.name":"router"}}
{"timestamp":"2024-07-09T11:49:09.792103959Z","level":"WARN","message":"plan_worker: an unknown error occurred TypeError: Error parsing args at position 1: serde_v8 error: invalid type; expected: object, got: string\n\n","target":"router_bridge::worker","resource":{"service.version":"1.50.0","service.name":"unknown_service:router","process.executable.name":"router"}}
{"timestamp":"2024-07-09T11:49:09.793025667Z","level":"ERROR","message":"panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/router-bridge-0.5.27+v2.8.1/src/worker.rs:104:38:\ncalled `Result::unwrap()` on an `Err` value: TypeError: Error parsing args at position 1: serde_v8 error: invalid type; expected: object, got: string\n    at send (worker.js:54:25)\n    at run (worker.js:171:19)","target":"apollo_router::executable","resource":{"service.version":"1.50.0","service.name":"unknown_service:router","process.executable.name":"router"}}

Our Dockerfile looks something like this:

FROM rust:1-bookworm as build
WORKDIR /usr/src/router

RUN apt-get update
RUN apt-get -y install \
    npm \
    protobuf-compiler \
    cmake

RUN rustup component add rustfmt

COPY . .

ARG BUILD_TYPE=release

RUN if [ "$BUILD_TYPE" = "release" ]; then \
    echo "Building in release mode"; \
    cargo build --release; \
else \
    echo "Building in debug mode"; \
    cargo build; \
fi

RUN mkdir -p /dist/config && \
    mkdir /dist/schema && \
    mv target/${BUILD_TYPE}/router /dist

FROM rust:1-slim-bookworm

RUN apt-get update
RUN apt-get -y install \
    ca-certificates

LABEL org.opencontainers.image.authors="Apollo Graph, Inc. https://github.com/apollographql/router"
LABEL org.opencontainers.image.source="https://github.com/apollographql/router"

COPY --from=build --chown=root:root /dist /dist

WORKDIR /dist

ENTRYPOINT ["/dist/router"]

I'm building on a Mac, but the same behaviour is observed also when building on Ubuntu machines.

[Geal]

the serde_v8 library has some requirements about the Rust version used to build it. You should build the router with the rust version we specify in the rust-toolchain.toml file (currently 1.76.0)