Port compose.directiveArgumentMergeStrategies.test.ts to router
#8311
+622
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 14a3218cfdd0a34d973a5c81 |
|
@conwuegb, please consider creating a changeset entry in |
dariuszkuc
reviewed
Sep 23, 2025
apollo-federation/src/schema/argument_composition_strategies.rs
Outdated
Show resolved
Hide resolved
tninesling
reviewed
Sep 25, 2025
dariuszkuc
previously requested changes
Sep 25, 2025
apollo-federation/tests/composition/directive_argument_merge_strategies.rs
Outdated
Show resolved
Hide resolved
apollo-federation/tests/composition/directive_argument_merge_strategies.rs
Show resolved
Hide resolved
apollo-federation/tests/composition/directive_argument_merge_strategies.rs
Outdated
Show resolved
Hide resolved
apollo-federation/tests/composition/directive_argument_merge_strategies.rs
Outdated
Show resolved
Hide resolved
apollo-federation/tests/composition/directive_argument_merge_strategies.rs
Outdated
Show resolved
Hide resolved
apollo-federation/tests/composition/directive_argument_merge_strategies.rs
Outdated
Show resolved
Hide resolved
apollo-federation/tests/composition/directive_argument_merge_strategies.rs
Outdated
Show resolved
Hide resolved
…nwuegb/fed-686
…irective arguments (#8487)
Most argument merging strategies are not used by public-facing directives, so the following strategies have been skipped: - min - intersection - nullable_and - nullable_max - nullable_union
Doing this in favor of converting that test into a unit test, as it is not trivial in Rust to define a custom directive from an integration test. This work will be associated with a new ticket: [FED-879](https://apollographql.atlassian.net/browse/FED-879)
…nwuegb/fed-686
10 tasks
duckki
approved these changes
Oct 31, 2025
[PR#8520](#8520) ports a behavior that propagates the correct error code.
…nwuegb/fed-686
…nwuegb/fed-686
conwuegb
dismissed
dariuszkuc’s stale review
Decided in standup to forgo using rstest in order to simplify the port. All other requested changes have been made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port tests from compose.directiveArgumentMergeStrategies.test.ts.
The tests could not be ported 1:1 since, in their original form, they are serving more as unit tests for the individual merge strategies than as integration tests. Instead of creating directives for each merge strategy, the Rust tests use existing directives as a proxy for the merge strategies themselves. At present, two merge strategies are not being used by existing directives so they were skipped in this port:
One particular test, "errors when declaring strategy that does not match the argument type", could not be ported using existing directives because a custom directive is required to be able to achieve that particular failure case. That test will be ported as a unit test in a future PR.
This change also adds a helper function for comparing
CompositionHints.An error was surfaced due to the additional error code checking added to composition::assert_composition_errors(...), so I've fixed it in this PR as well.
Checklist