Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to install rover on Windows 10 #1928

Closed
rquackenbush opened this issue Jun 14, 2024 · 4 comments · Fixed by #1975
Closed

Unable to install rover on Windows 10 #1928

rquackenbush opened this issue Jun 14, 2024 · 4 comments · Fixed by #1975
Labels
bug 🐞 triage issues and PRs that need to be triaged

Comments

@rquackenbush
Copy link

rquackenbush commented Jun 14, 2024

Description

Receiving error when attempting to install rover on Windows 10.

Steps to reproduce

I've run the following as a normal user and an admin in powershell 7.4.0:

iwr 'https://rover.apollo.dev/win/latest' | iex

Expected result

I expect rover to be installed.

Actual result

Downloading Rover from https://github.com/apollographql/rover/releases/download/v0.23.0/rover-v0.23.0-x86_64-pc-windows-msvc.tar.gz
error: unexpected argument '' found

Usage: rover.exe install [OPTIONS]

For more information, try '--help'.

Environment

rover isn't installed yet, so I can't run rover.

If you can't run rover info for some reason, please provide as much of the following info as possible:

  • Operating system and version:
    • OS Name: Microsoft Windows 10 Enterprise
    • OS Version: 10.0.19045 N/A Build 19045
  • Shell:: powershell 7.4.0
  • Version of Rover (rover --help): n/a
  • Apollo Studio Plan: none
  • Installation method: iwr
@rquackenbush rquackenbush added bug 🐞 triage issues and PRs that need to be triaged labels Jun 14, 2024
@LongLiveCHIEF
Copy link
Contributor

did you by chance have whitespace at the end of the command?

@rquackenbush
Copy link
Author

@LongLiveCHIEF - no. I just verified. No whitespace.

@rquackenbush
Copy link
Author

As best I can tell, the issue revolves around no arguments being passed into the script. I downloaded the powershell script and found that the error happens on this line of Install-Binary:

Invoke-Installer "$exe" "$rover_install_args"

It appears that $rover_install_args is empty. I have further confirmed that the call to Install-Binary has no value for $Args.

Is there an additional parameter I'm supposed to supply?

@rquackenbush
Copy link
Author

I was able to get rover installed by doing the following:

  • I downloaded the raw tar from: github
  • I extracted the file using the following command: tar -xkf rover-v0.23.0-x86_64-pc-windows-msvc.tar.gz "c:\Scratch\"
  • I executed (from c:\Scratch) .\rover.exe install
  • Exited powershell and started a new powershell terminal
  • I was able to run rover by running rover

jonathanrainer added a commit that referenced this issue Aug 29, 2024
…o Ensure No Regressions (#1975)

Fixes: #1928 

It seems that in certain situations whitespace is getting passed into
the script and messing up the Rover install command. This fixes that by
filtering out whitespace if it gets passed in.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 triage issues and PRs that need to be triaged
Projects
None yet
2 participants