Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing along offline enterprise license to router for rover dev #1937

Closed
brh55 opened this issue Jun 20, 2024 · 1 comment
Closed

Allow passing along offline enterprise license to router for rover dev #1937

brh55 opened this issue Jun 20, 2024 · 1 comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged

Comments

@brh55
Copy link
Member

brh55 commented Jun 20, 2024

Description

When spinning up the router in local development with rover dev the only way to pass along the enterprise license is to use either the environment variables or graph ref / apollo key w/ managed federation (which isn't useful for offline limited environments).

The router also supports a --license flag, which would be helpful to support passing along a similar flag in rover dev similarly to --supergraph-address or --supergraph-port
@brh55 brh55 added feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged labels Jun 20, 2024
@loshz loshz mentioned this issue Aug 27, 2024
Merged
loshz added a commit that referenced this issue Aug 28, 2024
@loshz
rover dev: add --license flag (#2078)
b7e427b 
## Description

As requested in #1937, this
PR adds the ability to pass along an offline enterprise license to the
router when running `rover dev`.
@loshz
Copy link
Contributor

loshz commented Aug 30, 2024

This functionality has been added and will be present in the next release of rover!

@loshz loshz closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loshz @brh55