feat: add YAML linting to local tests

- Add --yaml option to test-local.sh for YAML formatting tests
- Include YAML linting in default 'all' tests
- Test Kubernetes manifests in k8s/ directory
- Test router configuration YAML file
- Auto-install yamllint if not available
- Update test summary to include YAML formatting results

Author: smyrick

k8s/router-deployment-clusterip.yaml

@@ -17,21 +17,21 @@ spec:
         app: apollo-router
     spec:
       containers:
-      - name: apollo-router
-        image: ghcr.io/apollographql/router:v2.5.0
-        ports:
-          - containerPort: 4000
-            name: graphql
-          - containerPort: 8088
-            name: health
-        env:
-          - name: APOLLO_GRAPH_REF
-            value: "${APOLLO_GRAPH_REF}"
-          - name: APOLLO_KEY
-            value: "${APOLLO_KEY}"
-          - name: PORT
-            value: "4000"
-        volumeMounts:
+        - name: apollo-router
+          image: ghcr.io/apollographql/router:v2.5.0
+          ports:
+            - containerPort: 4000
+              name: graphql
+            - containerPort: 8088
+              name: health
+          env:
+            - name: APOLLO_GRAPH_REF
+              value: "${APOLLO_GRAPH_REF}"
+            - name: APOLLO_KEY
+              value: "${APOLLO_KEY}"
+            - name: PORT
+              value: "4000"
+          volumeMounts:
           - name: router-config
             mountPath: /dist/config.yaml
             subPath: config.yaml
@@ -62,13 +62,13 @@ spec:
             port: 8088
           initialDelaySeconds: 5
           periodSeconds: 5
-      volumes:
-        - name: router-config
-          configMap:
-            name: router-config
-        - name: supergraph-schema
-          configMap:
-            name: supergraph-schema
+        volumes:
+          - name: router-config
+            configMap:
+              name: router-config
+          - name: supergraph-schema
+            configMap:
+              name: supergraph-schema
 ---
 apiVersion: v1
 kind: Service

test-local.sh

@@ -27,19 +27,22 @@ show_usage() {
     echo "  -c, --composition      Test supergraph composition only"
     echo "  -d, --docker           Test Docker builds only"
     echo "  -r, --router           Test router only"
+    echo "  -y, --yaml             Test YAML formatting only"
     echo "  -h, --help             Show this help message"
     echo ""
     echo "Examples:"
     echo "  $0                     # Run all tests"
     echo "  $0 --subgraphs         # Test subgraphs only"
     echo "  $0 --composition       # Test composition only"
+    echo "  $0 --yaml              # Test YAML formatting only"
 }
 
 # Default values
 TEST_SUBGRAPHS=true
 TEST_COMPOSITION=true
 TEST_DOCKER=true
 TEST_ROUTER=true
+TEST_YAML=true
 
 # Parse command line arguments
 while [[ $# -gt 0 ]]; do
@@ -49,34 +52,47 @@ while [[ $# -gt 0 ]]; do
             TEST_COMPOSITION=true
             TEST_DOCKER=true
             TEST_ROUTER=true
+            TEST_YAML=true
             shift
             ;;
         -s|--subgraphs)
             TEST_SUBGRAPHS=true
             TEST_COMPOSITION=false
             TEST_DOCKER=false
             TEST_ROUTER=false
+            TEST_YAML=false
             shift
             ;;
         -c|--composition)
             TEST_SUBGRAPHS=false
             TEST_COMPOSITION=true
             TEST_DOCKER=false
             TEST_ROUTER=false
+            TEST_YAML=false
             shift
             ;;
         -d|--docker)
             TEST_SUBGRAPHS=false
             TEST_COMPOSITION=false
             TEST_DOCKER=true
             TEST_ROUTER=false
+            TEST_YAML=false
             shift
             ;;
         -r|--router)
             TEST_SUBGRAPHS=false
             TEST_COMPOSITION=false
             TEST_DOCKER=false
             TEST_ROUTER=true
+            TEST_YAML=false
+            shift
+            ;;
+        -y|--yaml)
+            TEST_SUBGRAPHS=false
+            TEST_COMPOSITION=false
+            TEST_DOCKER=false
+            TEST_ROUTER=false
+            TEST_YAML=true
             shift
             ;;
         -h|--help)
@@ -200,6 +216,50 @@ if [ "$TEST_DOCKER" = true ]; then
     print_success "Docker build test passed"
 fi
 
+# Test YAML formatting
+if [ "$TEST_YAML" = true ]; then
+    print_status "Testing YAML formatting..."
+    
+    # Check if yamllint is available
+    if ! command_exists yamllint; then
+        print_warning "yamllint not found, installing..."
+        if command_exists pip3; then
+            pip3 install yamllint
+        elif command_exists pip; then
+            pip install yamllint
+        else
+            print_error "pip not found, cannot install yamllint"
+            exit 1
+        fi
+    fi
+    
+    # Test all YAML files in k8s directory
+    if [ -d "k8s" ]; then
+        print_status "Linting Kubernetes manifests..."
+        yamllint k8s/ || {
+            print_error "YAML linting failed"
+            exit 1
+        }
+        print_success "Kubernetes manifests YAML linting passed"
+    else
+        print_warning "k8s directory not found, skipping YAML linting"
+    fi
+    
+    # Test router configuration YAML
+    if file_exists "router/router.yaml"; then
+        print_status "Linting router configuration..."
+        yamllint router/router.yaml || {
+            print_error "Router configuration YAML linting failed"
+            exit 1
+        }
+        print_success "Router configuration YAML linting passed"
+    else
+        print_warning "router/router.yaml not found, skipping"
+    fi
+    
+    print_success "YAML formatting test passed"
+fi
+
 # Test router and subgraphs functionality
 if [ "$TEST_ROUTER" = true ]; then
     print_status "Testing router and subgraphs functionality..."
@@ -311,6 +371,9 @@ fi
 if [ "$TEST_DOCKER" = true ]; then
     echo "  ✅ Docker builds"
 fi
+if [ "$TEST_YAML" = true ]; then
+    echo "  ✅ YAML formatting"
+fi
 if [ "$TEST_ROUTER" = true ]; then
     echo "  ✅ Router and subgraphs functionality"
 fi