Add Xcc flags that fixes crash on ESP32-C3.
#20
Conversation
This fixes apple#15, making the `smart-light` example run on ESP32-C3. I'm don't have enough knowledge to know if this is the proper fix/correct location to add these flags, but it makes the example work for me at least.
There was a problem hiding this comment.
hi @cheif, firstly thank you for the PR. I think we would like to take a slightly different approach to supporting the C3, please take a look at this recent PR to embedded examples for reference: apple/swift-embedded-examples@ab9a24c
|
Thanks for the feedback @rauhul! I've now update the PR to use a similar pattern as in the linked PR. Unfortunately I don't have access to any other ESP32 devices than the ESP32-C3, so I can't really test with other chips, but I've verified that it works on my ESP32-C3 at least. |
|
Try this pull request with |
|
I was out sick for the last couple weeks 😬, this diff looks good to me, @kubamracek can you also confirm before we merge this? |
|
LGTM. Do we also have a confirmation that the result actually works fully on a C3, and that it can connect to HomeKit and the smart light can be controlled? If yes, I would we would also want to update the README(s) to state that. |
|
@kubamracek I've managed to get the README:s are now updated to mention the ESP32C3 |
|
@rauhul @kubamracek Any chance of merging this soon? 😄 |
README.md
Outdated
| @@ -37,7 +37,8 @@ Before running the examples, ensure you have the following tools available: | |||
|
|
|||
| - Hardware: | |||
| - [ESP32-C6-DevKitC-1-N8](https://docs.espressif.com/projects/espressif-esp-dev-kits/en/latest/esp32c6/esp32-c6-devkitc-1/user_guide.html) | |||
| - Software | |||
| - The `smart-light` example is also tested using [Wemos C3 mini](https://www.wemos.cc/en/latest/c3/c3_mini.html) | |||
There was a problem hiding this comment.
I don't want to promise support for this board because Kuba and I have no way of verifying this.
README.md
Outdated
| @@ -64,12 +65,17 @@ Ensure your shell has access to the tools listed above, see [Get started on macO | |||
| $ idf.py set-target esp32c6 | |||
| ``` | |||
|
|
|||
| 3. Build and deploy the application to your device. | |||
| or (if using ESP32C3) | |||
There was a problem hiding this comment.
instead of a new "```shell" block can we note this in the text "Configure the build system for your microcontroller"?
I'd also like to see this reflected the the tutorial content as well
|
@rauhul I've updated the readme:s now. I'd also love for ESP32-C3 to be part of the tutorial, but unfortunately I don't have a good grasp on how to update it (nor the time to learn), so I'll have to leave that to someone else to update. |
This fixes #15, making the
smart-lightexample run on ESP32-C3.I'm don't have enough knowledge to know if this is the proper fix/correct location to add these flags, but it makes the example work for me at least.