-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export default process & runtime metrics #53
Comments
this is a cool idea @MrLotU, would you like to take on proposing an implementation? |
Sounds good, I suppose this could be done as extra module like "SystemMetrics" and added via Another tricky bit is labels -- this keeps coming up to be honest. I.e. one systems like to report like Gathering those may need some execution context? 🤔 Would be nice to figure this out and be able to offer it! Looking forward to more details :) |
I think separate module sounds good. not sure how to exactly tie it into bootstrap, so API ideas would be great to discuss
imo, the restriction logic on labels belong with the collector, not the emitter. iow collectors for backends that are sensitive to certain characters (like Prometheus and dots) should sanitize before sending to the backend. if we put this kind of logic on the generic emission API we would need to worry about all the potential disallowed characters in all the possible backends and this is not scalable. happy to consider suggestions that show otherwise.
+1 me too, this would be a great addition imo |
I'll get some work in over the weekend. Excited to see what we can do here 😄 |
Hmm, that is a fair point -- we could indeed handle this in the Prom library, by optionally providing some label replacements chars... This way users of apps who pick prom know "i have a lib which does use |
From the Prometheus client library spec,
Client libraries SHOULD offer what they can of the Standard exports, documented below.
I think these metrics would be useful to have, also outside of Prometheus.
My proposal is to implement these metrics into
swift-metrics
directly, with the option of switching them off.Possible API would be:
As a note I'd like to add I'm not 100% sure which of the above metrics are feasible and possible to get a hold of in Swift, so some experimentation/research might be needed there.
The text was updated successfully, but these errors were encountered: