Review comments

Author: FranzBusch

.github/workflows/benchmarks.yml

@@ -3,6 +3,13 @@ name: Benchmarks
 on:
   workflow_call:
     inputs:
+        benchmark_package_path:
+            type: string
+            description: "Path to the directory containing the benchmarking package. Defaults to ."
+            default: "."
+        swift_package_arguments:
+            type: string
+            description: "Arguments to the switch package command invocation e.g. `--disable-sandbox`"
         linux_5_8_enabled:
             type: boolean
             description: "Boolean to enable the Linux 5.8 Swift version matrix job. Defaults to true."
@@ -30,7 +37,7 @@ jobs:
         uses: ./.github/workflows/pull_request_swift_matrix.yml
         with:
           name: "Benchmarks"
-          matrix_linux_command: "apt-get update -y -q && apt-get install -y -q libjemalloc-dev && swift package --package-path Benchmarks/ --disable-sandbox benchmark baseline check --check-absolute-path Benchmarks/Thresholds/${SWIFT_VERSION}/"
+          matrix_linux_command: "apt-get update -y -q && apt-get install -y -q libjemalloc-dev && swift package --package-path ${{ inputs.benchmark_package_path }} ${{ inputs.swift_package_arguments }} benchmark baseline check --check-absolute-path ${{ inputs.benchmark_package_path }}/Thresholds/${SWIFT_VERSION}/"
           matrix_linux_5_8_enabled: ${{ inputs.linux_5_8_enabled }}
           matrix_linux_5_9_enabled: ${{ inputs.linux_5_9_enabled }}
           matrix_linux_5_10_enabled: ${{ inputs.linux_5_10_enabled }}

.github/workflows/cxx_interop.yml

@@ -30,9 +30,9 @@ jobs:
         uses: ./.github/workflows/pull_request_swift_matrix.yml
         with:
           name: "Cxx interop"
-          matrix_linux_command: "apt-get update -y -q && apt-get install -y -q jq && ./scripts/check-cxx-interop-compatibility.sh"
+          matrix_linux_command: "apt-get update -y -q && apt-get install -y -q jq && curl -s https://raw.githubusercontent.com/apple/swift-nio/main/scripts/check-cxx-interop-compatibility.sh | bash"
           matrix_linux_5_8_enabled: ${{ inputs.linux_5_8_enabled }}
           matrix_linux_5_9_enabled: ${{ inputs.linux_5_9_enabled }}
           matrix_linux_5_10_enabled: ${{ inputs.linux_5_10_enabled }}
           matrix_linux_nightly_6_0_enabled: ${{ inputs.linux_nightly_6_0_enabled }}
-          matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }}
+          matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }}

.github/workflows/pull_request_swift_matrix.yml

@@ -93,4 +93,4 @@ jobs:
         COMMAND_OVERRIDE_NIGHTLY_MAIN: ${{ inputs.matrix_linux_nightly_main_command_override }}
       run: |
         apt-get -qq update && apt-get -qq -y install curl
-        curl -s https://raw.githubusercontent.com/apple/swift-nio/main/scripts/check-matrix-job.sh | bash
+        curl -s https://raw.githubusercontent.com/apple/swift-nio/main/scripts/check-matrix-job.sh | bash

.github/workflows/unit_tests.yml

@@ -60,4 +60,4 @@ jobs:
           matrix_linux_nightly_6_0_enabled: ${{ inputs.linux_nightly_6_0_enabled }}
           matrix_linux_nightly_6_0_command_override: "swift test ${{ inputs.linux_nightly_6_0_arguments_override }}"
           matrix_linux_nightly_main_enabled: ${{ inputs.linux_nightly_main_enabled }}
-          matrix_linux_nightly_main_command_override: "swift test ${{ inputs.linux_nightly_main_arguments_override }}"
+          matrix_linux_nightly_main_command_override: "swift test ${{ inputs.linux_nightly_main_arguments_override }}"