Adopt ExistentialAny, MemberImportVisibility, InternalImportsByDefault, and NonIsolatedNonSendingByDefault (#38)

# Motivation

There are a few upcoming language features that we want to adopt to
adhere to the latest best practices

# Modifications

This PR enables these language features and fixes all errors and
warnings

# Result

Following the latest recommendations

Author: FranzBusch

.licenseignore

@@ -6,6 +6,7 @@
 .spi.yml
 .swift-format
 .github/
+Makefile
 **.md
 **.txt
 **.pb.swift

Examples/AsyncActivities/FilmPermitActivities.swift

@@ -21,10 +21,10 @@ import FoundationNetworking
 
 /// Activities for processing NYC film permits.
 @ActivityContainer
-public struct FilmPermitActivities {
+struct FilmPermitActivities {
     // MARK: - Data Models
 
-    public struct FilmPermit: Codable, Sendable {
+    struct FilmPermit: Codable, Sendable {
         let eventId: String
         let eventType: String
         let startDateTime: String
@@ -52,13 +52,13 @@ public struct FilmPermitActivities {
         }
     }
 
-    public struct ValidationResult: Codable, Sendable {
+    struct ValidationResult: Codable, Sendable {
         let permitId: String
         let isValid: Bool
         let issues: [String]
     }
 
-    public struct LocationAnalysis: Codable, Sendable {
+    struct LocationAnalysis: Codable, Sendable {
         let permitId: String
         let borough: String
         let precinct: String?
@@ -67,23 +67,23 @@ public struct FilmPermitActivities {
         let estimatedStreetCount: Int
     }
 
-    public struct PermitCategory: Codable, Sendable {
+    struct PermitCategory: Codable, Sendable {
         let permitId: String
         let category: String
         let subcategory: String
         let eventType: String
         let isCommercial: Bool
     }
 
-    public struct PermitAnalysis: Codable, Sendable {
+    struct PermitAnalysis: Codable, Sendable {
         let permit: FilmPermit
         let validation: ValidationResult
         let location: LocationAnalysis
         let category: PermitCategory
         let processingTimeMs: Double
     }
 
-    public struct AnalyticsReport: Codable, Sendable {
+    struct AnalyticsReport: Codable, Sendable {
         let totalPermits: Int
         let validPermits: Int
         let byBorough: [String: Int]

Examples/AsyncActivities/FilmPermitWorkflow.swift

@@ -17,23 +17,23 @@ import Temporal
 
 /// Workflow for processing NYC film permits with parallel and sequential modes.
 @Workflow
-public final class FilmPermitWorkflow {
-    public enum ProcessingMode: String, Codable, Sendable {
+final class FilmPermitWorkflow {
+    enum ProcessingMode: String, Codable, Sendable {
         case sequential
         case parallel
     }
 
-    public struct BatchRequest: Codable, Sendable {
+    struct BatchRequest: Codable, Sendable {
         let permits: [FilmPermitActivities.FilmPermit]
         let mode: ProcessingMode
     }
 
-    public struct BatchResult: Codable, Sendable {
+    struct BatchResult: Codable, Sendable {
         let report: FilmPermitActivities.AnalyticsReport
         let processingTimeMs: Double
     }
 
-    public func run(input: BatchRequest) async throws -> BatchResult {
+    func run(input: BatchRequest) async throws -> BatchResult {
         let startTime = Date()
 
         // Process permits based on mode (permits already fetched)

Examples/ChildWorkflows/PizzaOrderWorkflow.swift

@@ -12,6 +12,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+import Foundation
 import Temporal
 
 /// Parent workflow that orchestrates pizza order fulfillment.

Examples/ErrorHandling/ErrorHandlingActivities.swift

@@ -46,12 +46,12 @@ struct ErrorHandlingActivities {
 
     // MARK: - Fake Services
 
-    private let reservationService: ReservationService
-    private let paymentService: PaymentServiceProtocol
+    private let reservationService: any ReservationService
+    private let paymentService: any PaymentServiceProtocol
 
     init(
-        reservationService: ReservationService,
-        paymentService: PaymentServiceProtocol
+        reservationService: any ReservationService,
+        paymentService: any PaymentServiceProtocol
     ) {
         self.reservationService = reservationService
         self.paymentService = paymentService

Examples/ErrorHandling/ErrorHandlingWorkflow.swift

@@ -12,6 +12,7 @@
 //
 //===----------------------------------------------------------------------===//
 
+import Foundation
 import Temporal
 
 /// Demonstrates error handling and compensation patterns in Temporal workflows.

Examples/MultipleActivities/MultipleActivitiesActivities.swift

@@ -49,18 +49,18 @@ struct MultipleActivitiesActivities {
         let orderId: String
         let status: String
     }
-    private let inventoryService: InventoryService
-    private let paymentService: PaymentService
-    private let shippingService: ShippingService
-    private let notificationService: NotificationService
-    private let orderDatabase: OrderDatabase
+    private let inventoryService: any InventoryService
+    private let paymentService: any PaymentService
+    private let shippingService: any ShippingService
+    private let notificationService: any NotificationService
+    private let orderDatabase: any OrderDatabase
 
     init(
-        inventoryService: InventoryService,
-        paymentService: PaymentService,
-        shippingService: ShippingService,
-        notificationService: NotificationService,
-        orderDatabase: OrderDatabase
+        inventoryService: any InventoryService,
+        paymentService: any PaymentService,
+        shippingService: any ShippingService,
+        notificationService: any NotificationService,
+        orderDatabase: any OrderDatabase
     ) {
         self.inventoryService = inventoryService
         self.paymentService = paymentService

Makefile

@@ -0,0 +1,45 @@
+PROTO_OUT := ./Sources/Temporal/protos
+PROTO_BASE := ./dependencies/sdk-core/sdk-core-protos/protos
+PROTO_FILES := $(shell find $(PROTO_BASE) -name "*.proto" -not -path "*/google/*" -not -path "*/health/*")
+
+SWIFT_CONFIGURATION ?= debug
+SWIFT_BIN_PATH := $(shell swift build -c $(SWIFT_CONFIGURATION) --show-bin-path)
+
+PROTOC_GEN_SWIFT := $(shell swift build -c release --show-bin-path)/protoc-gen-swift
+PROTOC_GEN_GRPC_SWIFT := $(shell swift build -c release --show-bin-path)/protoc-gen-grpc-swift-2
+
+# Build swift protobuf generation tool using swift build for use in other steps
+$(PROTOC_GEN_SWIFT): Package.swift
+	swift build -c release --product protoc-gen-swift
+	swift build -c release --product protoc-gen-grpc-swift-2
+
+.PHONY: build-protos
+build-protos: $(PROTOC_GEN_SWIFT) $(PROTOC_GEN_GRPC_SWIFT) ./dependencies/sdk-core/sdk-core-protos/protos
+	rm -rf $(PROTO_OUT)
+	mkdir -p $(PROTO_OUT)
+	protoc --plugin $(PROTOC_GEN_SWIFT) \
+		--swift_out $(PROTO_OUT) \
+		--swift_opt=FileNaming=PathToUnderscores \
+		--swift_opt=Visibility=Package \
+		--swift_opt=UseAccessLevelOnImports=true \
+		-I ./dependencies/sdk-core/sdk-core-protos/protos/api_cloud_upstream \
+		-I ./dependencies/sdk-core/sdk-core-protos/protos/api_upstream \
+		-I ./dependencies/sdk-core/sdk-core-protos/protos/google \
+        -I ./dependencies/sdk-core/sdk-core-protos/protos/grpc \
+		-I ./dependencies/sdk-core/sdk-core-protos/protos/local \
+        -I ./dependencies/sdk-core/sdk-core-protos/protos/testsrv_upstream \
+		${PROTO_FILES}
+	protoc --plugin $(PROTOC_GEN_GRPC_SWIFT) \
+		--grpc-swift-2_out $(PROTO_OUT) \
+		--grpc-swift-2_opt=FileNaming=PathToUnderscores \
+		--grpc-swift-2_opt=Visibility=Package \
+		--grpc-swift-2_opt=UseAccessLevelOnImports=true \
+		--grpc-swift-2_opt=Client=true \
+		--grpc-swift-2_opt=Server=false \
+		-I ./dependencies/sdk-core/sdk-core-protos/protos/api_cloud_upstream \
+		-I ./dependencies/sdk-core/sdk-core-protos/protos/api_upstream \
+		-I ./dependencies/sdk-core/sdk-core-protos/protos/google \
+		-I ./dependencies/sdk-core/sdk-core-protos/protos/grpc \
+		-I ./dependencies/sdk-core/sdk-core-protos/protos/local \
+		-I ./dependencies/sdk-core/sdk-core-protos/protos/testsrv_upstream \
+		${PROTO_FILES}

Package.swift

@@ -255,3 +255,25 @@ let package = Package(
         ),
     ]
 )
+
+for target in package.targets
+where [.executable, .test, .regular].contains(
+    target.type
+) {
+    var settings = target.swiftSettings ?? []
+
+    // https://github.com/apple/swift-evolution/blob/main/proposals/0335-existential-any.md
+    // Require `any` for existential types.
+    settings.append(.enableUpcomingFeature("ExistentialAny"))
+
+    // https://github.com/swiftlang/swift-evolution/blob/main/proposals/0444-member-import-visibility.md
+    settings.append(.enableUpcomingFeature("MemberImportVisibility"))
+
+    // https://github.com/swiftlang/swift-evolution/blob/main/proposals/0409-access-level-on-imports.md
+    settings.append(.enableUpcomingFeature("InternalImportsByDefault"))
+
+    // https://github.com/swiftlang/swift-evolution/blob/main/proposals/0461-async-function-isolation.md
+    settings.append(.enableUpcomingFeature("NonIsolatedNonSendingByDefault"))
+
+    target.swiftSettings = settings
+}

Sources/Temporal/API/Common/Callback.swift

@@ -12,7 +12,7 @@
 //
 //===----------------------------------------------------------------------===//
 
-import struct Foundation.Data
+public import struct Foundation.Data
 
 /// Callback to attach to various events in the system (workflow run completion).
 public struct Callback: Hashable, Sendable {