Explicitly give signals and slots when calling connect

[oktomus]

Instead of doing

connect(
    m_viewport_widget, SIGNAL(customContextMenuRequested(const QPoint&)),
    SLOT(slot_viewport_widget_context_menu(const QPoint&)));

do

connect(
    m_viewport_widget, &ViewportWidget::customContextMenuRequested,
    this, &FinalRenderViewportTab::slot_viewport_widget_context_menu);

This allows to detect connect errors at compile time instead of runtime.
Also, navigating to signals or slots in Visual Studio is easier.

For signals or slots that have multiple arg possibilities, you can specify which one to chose with qOverload. Example, this

connect(
    m_display_transform_combo, SIGNAL(currentIndexChanged(QString)),
    m_viewport_widget, SLOT(slot_display_transform_changed(QString)));

becomes

connect(
    m_display_transform_combo, qOverload<const QString&>(&QComboBox::currentIndexChanged),
    m_viewport_widget, &ViewportWidget::slot_display_transform_changed);

[LeaBroudo]

I'd like to work on this issue, as I'm new to appleseed. Are there any particular files I can find this in? grep is taking a bit too long.

[oktomus]

@LeaBroudo run grep in a specific folder. For instance src/appleseed.studio.

[LeaBroudo]

Got it! I'll start on it now.