Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Filters: UI does not represent the current filter #57

Open
J70P opened this issue Oct 15, 2022 · 9 comments
Open

Custom Filters: UI does not represent the current filter #57

J70P opened this issue Oct 15, 2022 · 9 comments

Comments

@J70P
Copy link

J70P commented Oct 15, 2022

Steps to reproduce:

  1. Create a new note.
  2. Rename it to "A New Note (1).txt".
  3. Open "Custom Filters" in the main menu, select A and the button "Filter".
  4. Open again "Custom Filters" in the main menu, "all" is preselected, simple press the button "Filter".

-> nothing changes

Expected behavior: All notes are shown.

Maybe this is only an UI issue. If you scroll through the list of filters and select "all" it works as expected.

@appml
Copy link
Owner

appml commented Oct 18, 2022

Steps to reproduce:

  1. Create a new note.
  2. Rename it to "A New Note (1).txt".
  3. Open "Custom Filters" in the main menu, select A and the button "Filter".
  4. Open again "Custom Filters" in the main menu, "all" is preselected, simple press the button "Filter".

-> nothing changes

Expected behavior: All notes are shown.

Maybe this is only an UI issue. If you scroll through the list of filters and select "all" it works as expected.

You might have other starred notes? They take precedence over non starred notes.

HTH.

@J70P
Copy link
Author

J70P commented Oct 19, 2022

I made screenshots to clarify.

All notes unfiltered, select "Custom Filters" in the main menu. Select "A"

Screenshot_20221019-133824

and press the button "Filter".

Open again "Custom Filters"

Screenshot_20221019-133836

If you press now only the button "Filter", nothing happens.

if you scroll the filters back and forth a bit, it looks like this. That's why I thought it was just an UI issue. if you select "all" by scrolling in the list and press the button "Filter", you get the desired result.

Screenshot_20221019-133852

@appml
Copy link
Owner

appml commented Oct 19, 2022

Couldn't reproduce from my tests. Do you see the same results when you use gestures (switch filters by swiping left / right on the status bar)?

@J70P
Copy link
Author

J70P commented Oct 19, 2022

Couldn't reproduce from my tests.

Hm, weird.

Do you see the same results when you use gestures (switch filters by swiping left / right on the status bar)?

Cool feature. Didn't know it existed.

Swiping left/right on the status bar toggles through the custom filters. No abnormality.

@J70P
Copy link
Author

J70P commented Oct 24, 2022

Couldn't reproduce from my tests.

You really couldn't reproduce it?

The order should be

starred
A
B

but it is

starred
all
B

And if you scroll the filters back and forth a bit, it gets

starred
A
B

what is correct.

@GfEW
Copy link

GfEW commented May 10, 2024

I can confirm there's something strange going on with the display of filter A in the custom filter list.

Edit: Huh, why is the screen recording not embedded? Please, copy and visit the video URL on your own if the video isn't visible.

screen recording ![screenrecording_NeutriNote_bug-in-custom-filters_2024-05-10.mp4](https://github.com/appml/neutrinote/assets/15276963/83b10718-391b-4e84-9433-d674bb39f5d3)

In the above screen recording, you can see the following:

  • 00:02 min
    In NN 4.5.1c showing an unfiltered view of all notes, I tap main menu --> custom filters. As you can see, the initial list goes due/all/start/A/B..., but once I tap at A, it becomes due/all/start/all/B.... More taps at the new all (formerly A) don't revert it to A, but scrolling does revert it. Tapping at other letters does not alter them. Finally tapping filter when list focus is at A filters the notes correctly.
  • 00:26 min
    Tapping main menu --> custom filters a second time, the filter list reads due/all/start/all/B.... Again, tapping at the all (formerly A) item doesn't revert it to A, but scrolling does. Tapping filter again with that reverted A in focus keeps the list filtered.
  • 00:35 min
    Tapping main menu --> custom filters a third time, the filter list still goes due/all/start/all/B.... Tapping filter with that fake all in focus keeps the list filtered as if filter A was still effective. (I think this demonstrates the actual issue as reported by @J70P.)
  • 00:39 min
    Tapping main menu --> custom filters the fourth time, the filter list unsurprisingly still reads due/all/start/all/B... and can, by a little scrolling, be reverted to due/all/start/A/B.... Tapping filter then again with the real, original all item in focus correctly resets the filter to empty, showing all notes, as expected.

@appml
Copy link
Owner

appml commented May 12, 2024

I can confirm there's something strange going on with the display of filter A in the custom filter list.

Edit: Huh, why is the screen recording not embedded? Please, copy and visit the video URL on your own if the video isn't visible.

screen recording
In the above screen recording, you can see the following:

  • 00:02 min
    In NN 4.5.1c showing an unfiltered view of all notes, I tap main menu --> custom filters. As you can see, the initial list goes due/all/start/A/B..., but once I tap at A, it becomes due/all/start/all/B.... More taps at the new all (formerly A) don't revert it to A, but scrolling does revert it. Tapping at other letters does not alter them. Finally tapping filter when list focus is at A filters the notes correctly.
  • 00:26 min
    Tapping main menu --> custom filters a second time, the filter list reads due/all/start/all/B.... Again, tapping at the all (formerly A) item doesn't revert it to A, but scrolling does. Tapping filter again with that reverted A in focus keeps the list filtered.
  • 00:35 min
    Tapping main menu --> custom filters a third time, the filter list still goes due/all/start/all/B.... Tapping filter with that fake all in focus keeps the list filtered as if filter A was still effective. (I think this demonstrates the actual issue as reported by @J70P.)
  • 00:39 min
    Tapping main menu --> custom filters the fourth time, the filter list unsurprisingly still reads due/all/start/all/B... and can, by a little scrolling, be reverted to due/all/start/A/B.... Tapping filter then again with the real, original all item in focus correctly resets the filter to empty, showing all notes, as expected.

Any info about ROM or device model?

@GfEW
Copy link

GfEW commented May 14, 2024

Any info about ROM or device model?

I've tested the procedure shown in the screen recording on different android 9 to 11 devices (all stock ROM), ranging from commonplace Samsung J3 (android 9) to rather exotic Hisense A6 L (android 11). On all of them, all four steps behave exactly as described, with only one minor exception on an android 10 tablet, as follows.

On that tablet (which happens to have by far the largest sreen, and a stylus), tapping at the fake all filter with the stylus sporadically does revert it to A. However that might as well be due to some inadvertant micro-scrolling in the process of moving the tip towards or away from the screen (even if pure, non-sliding taps are attempted) because the stylus registers already 1 to 2 mm before actually touching the screen, and it's hard to go in a direction that is sufficiently orthogonal to the screen surface to not trigger any cursor sliding at all. Supposedly for the same reason, the initial A sporadically changes to all only by the second tap on that device (if the first tap attempt ends up being a micro-slide).

Therefore, this exception doesn't really disprove the bug on that device, either. As far as I can check with my devices, it's basically reproducible everywhere.

@appml
Copy link
Owner

appml commented May 16, 2024

Any info about ROM or device model?

I've tested the procedure shown in the screen recording on different android 9 to 11 devices (all stock ROM), ranging from commonplace Samsung J3 (android 9) to rather exotic Hisense A6 L (android 11). On all of them, all four steps behave exactly as described, with only one minor exception on an android 10 tablet, as follows.

On that tablet (which happens to have by far the largest sreen, and a stylus), tapping at the fake all filter with the stylus sporadically does revert it to A. However that might as well be due to some inadvertant micro-scrolling in the process of moving the tip towards or away from the screen (even if pure, non-sliding taps are attempted) because the stylus registers already 1 to 2 mm before actually touching the screen, and it's hard to go in a direction that is sufficiently orthogonal to the screen surface to not trigger any cursor sliding at all. Supposedly for the same reason, the initial A sporadically changes to all only by the second tap on that device (if the first tap attempt ends up being a micro-slide).

Therefore, this exception doesn't really disprove the bug on that device, either. As far as I can check with my devices, it's basically reproducible everywhere.

There are two parts of the problems. The next build should address the first part by keeping all steady in place.

Regarding the 2nd part, that is, the current value not reflected as the selected value and self correct upon a long press, is more likely an Android OS bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants