Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider alternatives for how app-specific overrides are provided #49

Open
hinerm opened this issue May 20, 2024 · 0 comments
Open

Consider alternatives for how app-specific overrides are provided #49

hinerm opened this issue May 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@hinerm
Copy link
Collaborator

hinerm commented May 20, 2024

jvm.root-paths determines the location Jaunch looks for Java versions.

Currently, this configuration is also specified in fiji.toml which aggregates jvm.toml. This causes the fiji.toml values to be prepended and thus completely take precedence over the jvm.toml versions - even though jvm.toml includes e.g. --java-home which should be an absolute override as a user flag.

@ctrueden suggested some alternatives:

  1. add a @{app-specific-root-paths} reference... somewhere... in jvm.toml which is then an extension point that can be leveraged in fiji.toml
  2. Just directly move the fiji.toml entry to jvm.toml
  3. Add a flag, i.e. $ (! is already taken for inverting hints), that when present in a list item causes the value to be appended instead of prepended
hinerm added a commit that referenced this issue May 21, 2024
Aggregated values are currently prepended, thus declaring a root
diretcory in fiji.toml takes precedence over ALL paths in jvm.toml,
making it impossible to update the Java version on x64 Mac in Fijis with
a bundled JVM.

See #49
@ctrueden ctrueden added the enhancement New feature or request label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants