Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryWriter #37

Open
markijbema opened this issue Feb 19, 2014 · 5 comments
Open

BinaryWriter #37

markijbema opened this issue Feb 19, 2014 · 5 comments

Comments

@markijbema
Copy link
Contributor

What's the status of BinaryWriter? Is it still used? If I comment the whole file out, not a single test fails, and 'BinaryWriter' is mentioned nowhere else in the source.

@kytrinyx
Copy link
Contributor

That may have been an experiment. Let's delete it.

@kytrinyx
Copy link
Contributor

Wait. Dang it. I can't remember if someone else submitted it. What does blame say?

@kytrinyx
Copy link
Contributor

Yeah, no. @badquanta added the binary writer, so I'll assume that it's in use.

@badquanta - would you confirm?

It's possible to configure which writer you want to use when you're writing the test, so it doesn't have to be mentioned elsewhere in the codebase to be used, but if it's in use we should add tests for it.

@ghost
Copy link

ghost commented Feb 20, 2014

I had been using it for a project that I've since let go inactive for a bit
but plan on returning to this summer. It approved S.D.L. lib generated
output. I'd still like the ability to dump and compare binaries, but if
someone wants to put in something that handles images specifically that
would be cool with me. And I'd be willing to help as much as I could.

On Wed, Feb 19, 2014 at 12:15 PM, Katrina Owen [email protected]:

Yeah, no. @badquanta https://github.com/BadQuanta added the binary
writer, so I'll assume that it's in use.

@badquanta https://github.com/BadQuanta - would you confirm?

It's possible to configure which writer you want to use when you're
writing the test, so it doesn't have to be mentioned elsewhere in the
codebase to be used, but if it's in use we should add tests for it.

Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-35542977
.

Jon S.

Email: [email protected]

@kytrinyx
Copy link
Contributor

Ok, cool. I vote to keep it in. I'll look at adding a test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants