You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi !
I recently stumbled upon Approval testing and am very glad some people made a library for it in php, thank you for that !
I am currently trying (for a class project) to upgrade a legacy application ( php 5.6, symfony 3.1) which contains a few controllers and wanted to setup approval tests before trying to upgrade/refacto the existing code base.
I ended up with the following error while trying to setup a simple test (your given example actually):
Parse error: syntax error, unexpected ':', expecting ';' or '{' in .../vendor/approvals/approval-tests/src/Namers/PHPUnitNamer.php on line 71
And even the simple testList() returns the error mentioned earlier.
If it is any help, I am working through docker with a custom image of php-fpm-5.6-alpine, phpunit is at 5.7 version.
Thanks in advance and if you need any more details I would happily provide !
The text was updated successfully, but these errors were encountered:
it seems that the return type of __toString is the reason of your issue. I opened a MR which can easily "fix" this problem.
BTW: Why do you work with PHP 5.6 in 2022?
Hi @vansari , thank you for responding and taking the time to have a look !
I actually do not work with PHP 5.6 on a day to day basis (and I am glad I don't have to), it was the specific goal of a school project to upgrade an old application to a more recent version ;)
Hi !
I recently stumbled upon Approval testing and am very glad some people made a library for it in php, thank you for that !
I am currently trying (for a class project) to upgrade a legacy application ( php 5.6, symfony 3.1) which contains a few controllers and wanted to setup approval tests before trying to upgrade/refacto the existing code base.
I ended up with the following error while trying to setup a simple test (your given example actually):
Parse error: syntax error, unexpected ':', expecting ';' or '{' in .../vendor/approvals/approval-tests/src/Namers/PHPUnitNamer.php on line 71
My Test Case is the following:
And even the simple testList() returns the error mentioned earlier.
If it is any help, I am working through docker with a custom image of php-fpm-5.6-alpine, phpunit is at 5.7 version.
Thanks in advance and if you need any more details I would happily provide !
The text was updated successfully, but these errors were encountered: