Skip to content

Commit 0486f7d

Browse files
unflxwjeffkreeftmeijer
authored andcommitted
Exclude Padrino and Hanami from Ruby 4 CI
Padrino and Hanami have dependencies that ultimately depend on `bundler < 3`. This makes them incompatible with Ruby 4 for the time being. We should re-assess this after Ruby 4 is released and the affected libraries release the necessary updates.
1 parent e08bfac commit 0486f7d

File tree

2 files changed

+4
-112
lines changed

2 files changed

+4
-112
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 109 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# This is a generated file by the `rake build_matrix:github:generate` task.
33
# See `build_matrix.yml` for the build matrix.
44
# Generate this file with `rake build_matrix:github:generate`.
5-
# Generated job count: 223
5+
# Generated job count: 219
66
---
77
name: Ruby gem CI
88
'on':
@@ -238,87 +238,6 @@ jobs:
238238
JRUBY_OPTS: ''
239239
COV: '1'
240240
BUNDLE_GEMFILE: gemfiles/grape.gemfile
241-
ruby_4-0-0-preview2__hanami-2-0_ubuntu-latest:
242-
name: Ruby 4.0.0-preview2 - hanami-2.0
243-
needs: ruby_4-0-0-preview2_ubuntu-latest
244-
runs-on: ubuntu-latest
245-
steps:
246-
- name: Check out repository
247-
uses: actions/checkout@v4
248-
- name: Install Ruby
249-
uses: ruby/setup-ruby@v1
250-
with:
251-
ruby-version: 4.0.0-preview2
252-
bundler-cache: true
253-
- name: Install gem extension
254-
run: "./script/bundler_wrapper exec rake extension:install"
255-
- name: Print extension install report
256-
run: "[ -e ext/install.report ] && cat ext/install.report || echo 'No ext/install.report
257-
file found'"
258-
- name: Print Makefile log file
259-
run: "[ -f ext/mkmf.log ] && cat ext/mkmf.log || echo 'No ext/mkmf.log file
260-
found'"
261-
- name: Run tests
262-
run: "./script/bundler_wrapper exec rake test"
263-
env:
264-
RAILS_ENV: test
265-
JRUBY_OPTS: ''
266-
COV: '1'
267-
BUNDLE_GEMFILE: gemfiles/hanami-2.0.gemfile
268-
ruby_4-0-0-preview2__hanami-2-1_ubuntu-latest:
269-
name: Ruby 4.0.0-preview2 - hanami-2.1
270-
needs: ruby_4-0-0-preview2_ubuntu-latest
271-
runs-on: ubuntu-latest
272-
steps:
273-
- name: Check out repository
274-
uses: actions/checkout@v4
275-
- name: Install Ruby
276-
uses: ruby/setup-ruby@v1
277-
with:
278-
ruby-version: 4.0.0-preview2
279-
bundler-cache: true
280-
- name: Install gem extension
281-
run: "./script/bundler_wrapper exec rake extension:install"
282-
- name: Print extension install report
283-
run: "[ -e ext/install.report ] && cat ext/install.report || echo 'No ext/install.report
284-
file found'"
285-
- name: Print Makefile log file
286-
run: "[ -f ext/mkmf.log ] && cat ext/mkmf.log || echo 'No ext/mkmf.log file
287-
found'"
288-
- name: Run tests
289-
run: "./script/bundler_wrapper exec rake test"
290-
env:
291-
RAILS_ENV: test
292-
JRUBY_OPTS: ''
293-
COV: '1'
294-
BUNDLE_GEMFILE: gemfiles/hanami-2.1.gemfile
295-
ruby_4-0-0-preview2__hanami-2-2_ubuntu-latest:
296-
name: Ruby 4.0.0-preview2 - hanami-2.2
297-
needs: ruby_4-0-0-preview2_ubuntu-latest
298-
runs-on: ubuntu-latest
299-
steps:
300-
- name: Check out repository
301-
uses: actions/checkout@v4
302-
- name: Install Ruby
303-
uses: ruby/setup-ruby@v1
304-
with:
305-
ruby-version: 4.0.0-preview2
306-
bundler-cache: true
307-
- name: Install gem extension
308-
run: "./script/bundler_wrapper exec rake extension:install"
309-
- name: Print extension install report
310-
run: "[ -e ext/install.report ] && cat ext/install.report || echo 'No ext/install.report
311-
file found'"
312-
- name: Print Makefile log file
313-
run: "[ -f ext/mkmf.log ] && cat ext/mkmf.log || echo 'No ext/mkmf.log file
314-
found'"
315-
- name: Run tests
316-
run: "./script/bundler_wrapper exec rake test"
317-
env:
318-
RAILS_ENV: test
319-
JRUBY_OPTS: ''
320-
COV: '1'
321-
BUNDLE_GEMFILE: gemfiles/hanami-2.2.gemfile
322241
ruby_4-0-0-preview2__http5_ubuntu-latest:
323242
name: Ruby 4.0.0-preview2 - http5
324243
needs: ruby_4-0-0-preview2_ubuntu-latest
@@ -373,33 +292,6 @@ jobs:
373292
JRUBY_OPTS: ''
374293
COV: '1'
375294
BUNDLE_GEMFILE: gemfiles/ownership.gemfile
376-
ruby_4-0-0-preview2__padrino_ubuntu-latest:
377-
name: Ruby 4.0.0-preview2 - padrino
378-
needs: ruby_4-0-0-preview2_ubuntu-latest
379-
runs-on: ubuntu-latest
380-
steps:
381-
- name: Check out repository
382-
uses: actions/checkout@v4
383-
- name: Install Ruby
384-
uses: ruby/setup-ruby@v1
385-
with:
386-
ruby-version: 4.0.0-preview2
387-
bundler-cache: true
388-
- name: Install gem extension
389-
run: "./script/bundler_wrapper exec rake extension:install"
390-
- name: Print extension install report
391-
run: "[ -e ext/install.report ] && cat ext/install.report || echo 'No ext/install.report
392-
file found'"
393-
- name: Print Makefile log file
394-
run: "[ -f ext/mkmf.log ] && cat ext/mkmf.log || echo 'No ext/mkmf.log file
395-
found'"
396-
- name: Run tests
397-
run: "./script/bundler_wrapper exec rake test"
398-
env:
399-
RAILS_ENV: test
400-
JRUBY_OPTS: ''
401-
COV: '1'
402-
BUNDLE_GEMFILE: gemfiles/padrino.gemfile
403295
ruby_4-0-0-preview2__psych-3_ubuntu-latest:
404296
name: Ruby 4.0.0-preview2 - psych-3
405297
needs: ruby_4-0-0-preview2_ubuntu-latest

build_matrix.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@ matrix:
156156
- gem: "hanami-2.0"
157157
only:
158158
ruby:
159-
- "4.0.0-preview2"
160159
- "3.5.0-preview1"
161160
- "3.4.1"
162161
- "3.3.4"
@@ -166,7 +165,6 @@ matrix:
166165
- gem: "hanami-2.1"
167166
only:
168167
ruby:
169-
- "4.0.0-preview2"
170168
- "3.5.0-preview1"
171169
- "3.4.1"
172170
- "3.3.4"
@@ -176,7 +174,6 @@ matrix:
176174
- gem: "hanami-2.2"
177175
only:
178176
ruby:
179-
- "4.0.0-preview2"
180177
- "3.5.0-preview1"
181178
- "3.4.1"
182179
- "3.3.4"
@@ -185,6 +182,9 @@ matrix:
185182
- gem: "http5"
186183
- gem: "ownership"
187184
- gem: "padrino"
185+
exclude:
186+
ruby:
187+
- "4.0.0-preview2"
188188
- gem: "psych-3"
189189
only:
190190
ruby:

0 commit comments

Comments
 (0)