Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore inexisting resources #43

Merged
merged 6 commits into from
Nov 17, 2020
Merged

Ignore inexisting resources #43

merged 6 commits into from
Nov 17, 2020

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Nov 13, 2020

Closes #42

@ccremer ccremer requested a review from zugao November 13, 2020 15:26
@ccremer
Update Go to 1.15
2d9872a 
Signed-off-by: Chris <[email protected]>
@ccremer
Skip deleting of objects that aren't found anymore
b28eed9 
Should not abort anymore when the candidate has been deleted in the meantime.

Signed-off-by: Chris <[email protected]>
@ccremer
Update Badges
d77ed47 
Signed-off-by: Chris <[email protected]>
@ccremer ccremer changed the title Ignore deleted resources Ignore inexisting resources Nov 13, 2020
zugao
zugao approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccremer ccremer merged commit ca67410 into master Nov 17, 2020
@ccremer ccremer deleted the ignore-deleted branch November 17, 2020 09:11
@srueg srueg added the bug Something isn't working label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seiso should not raise error if configuration has already been deleted
4 participants
@ccremer @zugao @srueg @renovate-bot