From 623098d446eb5ab8619d8f85fded9cdd1dbde58f Mon Sep 17 00:00:00 2001 From: App Upgrade Date: Sun, 26 Feb 2023 20:44:57 +0530 Subject: [PATCH] Fix issue #1 --- CHANGELOG.md | 6 +++++- README.md | 2 +- .../app_upgrade_android_sdk/AppUpgradeRepository.kt | 12 ++++++++---- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e7715af..19fce6a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,11 @@ All notable changes will be documented in this file. -## [1.0.3] - 2023-01-16 +## [1.0.3] - 2023-02-26 + +* Fix issue [#1](https://github.com/appupgrade-dev/app-upgrade-android-sdk/issues/1). + +## [1.0.2] - 2023-01-16 * Add localization support for update message. diff --git a/README.md b/README.md index 38629ab..bbe00c5 100644 --- a/README.md +++ b/README.md @@ -51,7 +51,7 @@ allprojects { 2. Add the dependency to your project ```groovy dependencies { - implementation 'com.github.appupgrade-dev:app-upgrade-android-sdk:1.0.2' + implementation 'com.github.appupgrade-dev:app-upgrade-android-sdk:1.0.3' } ``` diff --git a/app-upgrade-android-sdk/src/main/java/com/appupgrade/app_upgrade_android_sdk/AppUpgradeRepository.kt b/app-upgrade-android-sdk/src/main/java/com/appupgrade/app_upgrade_android_sdk/AppUpgradeRepository.kt index 4dcce38..0bd917c 100644 --- a/app-upgrade-android-sdk/src/main/java/com/appupgrade/app_upgrade_android_sdk/AppUpgradeRepository.kt +++ b/app-upgrade-android-sdk/src/main/java/com/appupgrade/app_upgrade_android_sdk/AppUpgradeRepository.kt @@ -82,7 +82,7 @@ fun showForceUpgradePopup(parentActivity: Activity, appId: String, updateMessage: String, alertDialogConfig: AlertDialogConfig?) { Log.d("App Upgrade: ", "Show force upgrade popup.") - Thread { + if (!parentActivity.isFinishing) { parentActivity.runOnUiThread { val builder = AlertDialog.Builder(parentActivity) builder.setMessage(updateMessage) @@ -109,13 +109,15 @@ alert.setTitle(alertDialogTitle) alert.show() } - }.start() + } else { + Log.d("App Upgrade Err: ", "Parent activity is finished running.") + } } fun showUpgradePopup(parentActivity: Activity, appId: String, updateMessage: String, alertDialogConfig: AlertDialogConfig?) { Log.d("App Upgrade: ", "Show upgrade popup.") - Thread { + if (!parentActivity.isFinishing) { parentActivity.runOnUiThread { val builder = AlertDialog.Builder(parentActivity) builder.setMessage(updateMessage) @@ -152,7 +154,9 @@ alert.setTitle(alertDialogTitle) alert.show() } - }.start() + } else { + Log.d("App Upgrade Err: ", "Parent activity is finished running.") + } } private fun onUserLater() {