Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #4

Open
mattlennon3 opened this issue Aug 22, 2023 · 1 comment
Open

Improvements #4

mattlennon3 opened this issue Aug 22, 2023 · 1 comment

Comments

@mattlennon3
Copy link

Hi,

Really liking the service and library so far.

I have a few improvements to suggest:

  • The try/catch & log on line 50 of api.js is not very useful to the caller of the function.
    • It feels like as the caller, I cannot handle the error and decide what to do. I think you should just throw the error. Or at least return false.
    • There are also logs that we may not even want to be logged in our app (we have a custom logger). So Ideally, this library would not log anything, but would either return some success object or error. Which we can handle and log as appropriate.
  • You guys are using axiosRetry. I would add the retry attempts as a parameter so we can control this. i.e if we only wanted to check when the app first opens.
  • Typescript support
@appupgrade-dev
Copy link
Owner

@mattlennon3 Thanks a lot for the suggestions. We will reflect on them and will make appropriate changes in the upcoming releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants