Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing depth parameter #3876

Open
ttodua opened this issue May 19, 2023 · 4 comments
Open

missing depth parameter #3876

ttodua opened this issue May 19, 2023 · 4 comments

Comments

@ttodua
Copy link

ttodua commented May 19, 2023

in appveyor.yml you can set clone_depth:1 however the fetch that is being made :

https://ci.appveyor.com/project/ccxt/ccxt/builds/47088338#L3

does not respect depth:1 and it fetches full ref, which is around 3gb for that specific repo in my example link. The same issue was happening in travis, and we reported them and they have fixed (now they use depth param, i.e. https://app.travis-ci.com/github/ccxt/ccxt/builds/263174800#L173 ).

So, please add depth param in appveyor too.

@FeodorFitsner
Copy link
Member

Sure, in the meantime you can use a custom clone script:

clone_script:
- ps: |
    if(-not $env:appveyor_pull_request_number) {
        git clone -q --branch=$env:appveyor_repo_branch https://github.com/$env:appveyor_repo_name.git $env:appveyor_build_folder
        git checkout -qf $env:appveyor_repo_commit
    } else {
        git clone -q https://github.com/$env:appveyor_repo_name.git $env:appveyor_build_folder
        git fetch -q origin +refs/pull/$env:appveyor_pull_request_number/merge:
        git checkout -qf FETCH_HEAD
    }

@ttodua
Copy link
Author

ttodua commented May 22, 2023

thanks! plz let us know whenever it will be implemented

@ttodua
Copy link
Author

ttodua commented Jun 2, 2023

any chance to add depth param like it's here on 173th line? https://app.travis-ci.com/github/ccxt/ccxt/builds/263174800#L173

@ttodua
Copy link
Author

ttodua commented Jan 25, 2024

@FeodorFitsner any thoughts whether this can be fixed? if you look into https://ci.appveyor.com/project/ccxt/ccxt/history you will see that 3GB of repo is being fetched on each commit. it is huge performance penalty, so you might fix that problem, i think other repos will be bleeding from that too.

the similar issue was on travis, and after i had reported, they had fixed it a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants