-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Appium 9.2.3 and Selenium 4.22.0 #43
Conversation
Update device and driver settings to use BaseOptions instead of Capabilities (in accordance with changes introduced in latest version, see appium/java-client#2184)
WalkthroughThis update primarily focuses on upgrading dependency versions in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- pom.xml (2 hunks)
- src/main/java/aquality/appium/mobile/configuration/DeviceSettings.java (2 hunks)
- src/main/java/aquality/appium/mobile/configuration/DriverSettings.java (3 hunks)
- src/main/java/aquality/appium/mobile/configuration/IDeviceSettings.java (2 hunks)
- src/main/java/aquality/appium/mobile/configuration/IDriverSettings.java (2 hunks)
Additional comments not posted (12)
src/main/java/aquality/appium/mobile/configuration/IDeviceSettings.java (2)
3-3
: Approved import change fromCapabilities
toBaseOptions
.This change is consistent with the PR's goal to update to the latest versions of Appium and Selenium, which use
BaseOptions
instead ofCapabilities
.
12-14
: Approved method signature change to returnBaseOptions<?>
.The update to return
BaseOptions<?>
instead ofCapabilities
aligns with the new standards introduced by the updated versions of Appium and Selenium.src/main/java/aquality/appium/mobile/configuration/IDriverSettings.java (2)
3-3
: Approved import change fromCapabilities
toBaseOptions
.This change is consistent with the PR's goal to update to the latest versions of Appium and Selenium, which use
BaseOptions
instead ofCapabilities
.
12-14
: Approved method signature change to returnBaseOptions<?>
.The update to return
BaseOptions<?>
instead ofCapabilities
aligns with the new standards introduced by the updated versions of Appium and Selenium.src/main/java/aquality/appium/mobile/configuration/DeviceSettings.java (2)
5-5
: Approved import change fromCapabilities
toBaseOptions
.This change is consistent with the PR's goal to update to the latest versions of Appium and Selenium, which use
BaseOptions
instead ofCapabilities
.
29-31
: Approved method implementation change to useBaseOptions<?>
.The implementation of
getCapabilities
usingBaseOptions<?>
is correct and aligns with the updated interface. Ensure thatsetCapability
is correctly implemented inBaseOptions
.src/main/java/aquality/appium/mobile/configuration/DriverSettings.java (2)
7-7
: Approved import change fromCapabilities
toBaseOptions
.This change is consistent with the PR's goal to update to the latest versions of Appium and Selenium, which use
BaseOptions
instead ofCapabilities
.
31-33
: Approved method implementation changes to useBaseOptions<?>
.The implementations of
getCapabilities
andgetDeviceCapabilities
usingBaseOptions<?>
are correct and align with the updated interface. Ensure thatsetCapability
andmerge
are correctly implemented inBaseOptions
.Also applies to: 70-70
pom.xml (4)
192-192
: Approved version update foraquality-selenium-core
.The update from
4.0.2
to4.0.3
is minor and likely non-breaking. However, ensure compatibility with other updated dependencies.
198-198
: Approved version update forjava-client
.The update to
9.2.3
aligns with the PR's objective of updating Appium. This is a patch version update, usually safe and focused on bug fixes.
204-204
: Approved version update fortestng
.The update from
7.9.0
to7.10.2
is a minor version change. Review the release notes fortestng
to ensure compatibility and understand any new features or breaking changes.
218-218
: Approved version update forcommons-io
.The update from
2.15.1
to2.16.1
is minor and typically involves bug fixes or performance improvements. Ensure it does not introduce issues with other libraries.
Update device and driver settings to use BaseOptions instead of Capabilities
(in accordance with changes introduced in latest version, see appium/java-client#2184)