Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): use remote repositories from settings.xml for pom.xml files #7807

Open
DmitriyLewen opened this issue Oct 29, 2024 Discussed in #7175 · 0 comments
Open

feat(java): use remote repositories from settings.xml for pom.xml files #7807

DmitriyLewen opened this issue Oct 29, 2024 Discussed in #7175 · 0 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@DmitriyLewen
Copy link
Contributor

Description

We currently get repositories from pom.xml files + maven central:

// Update remoteRepositories
pomReleaseRemoteRepos, pomSnapshotRemoteRepos := pom.repositories(p.servers)
p.releaseRemoteRepos = lo.Uniq(append(pomReleaseRemoteRepos, p.releaseRemoteRepos...))
p.snapshotRemoteRepos = lo.Uniq(append(pomSnapshotRemoteRepos, p.snapshotRemoteRepos...))

But settings.xml file may also contain remote repositories.
We need to add logic to get repositories from this file.
See more details in #7175

Discussed in #7175

@DmitriyLewen DmitriyLewen added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants
@DmitriyLewen and others