diff --git a/README.md b/README.md index 58c2539..4fca101 100644 --- a/README.md +++ b/README.md @@ -254,13 +254,13 @@ This plugin is upgradeable. #### Methods ```solidity -function initialize(IDAO _dao, string _firstBlockContentUri, address predecessorSpace); +function initialize(IDAO _dao, string _firstContentUri, address predecessorSpace); -function publishEdits(uint32 _blockIndex, uint32 _itemIndex, string _contentUri); +function publishEdits(string _contentUri); -function acceptSubspace(address _dao); +function acceptSubspace(address _subspaceDao); -function removeSubspace(address _dao); +function removeSubspace(address _subspaceDao); ``` Inherited: @@ -282,10 +282,10 @@ function implementation() returns (address); #### Events ```solidity -event EditsPublished(uint32 blockIndex, uint32 itemIndex, string contentUri); -event SuccessorSpaceCreated(address predecessorSpace); -event SubspaceAccepted(address dao); -event SubspaceRemoved(address dao); +event EditsPublished(address dao, string contentUri); +event SuccessorSpaceCreated(address dao, address predecessorSpaceDao); +event SubspaceAccepted(address dao, address subspaceDao); +event SubspaceRemoved(address dao, address subspaceDao); ``` #### Permissions diff --git a/packages/contracts/test/unit-testing/personal-space-admin-plugin.ts b/packages/contracts/test/unit-testing/personal-space-admin-plugin.ts index 2d5f5e4..3c43894 100644 --- a/packages/contracts/test/unit-testing/personal-space-admin-plugin.ts +++ b/packages/contracts/test/unit-testing/personal-space-admin-plugin.ts @@ -43,6 +43,15 @@ export const defaultInitData: InitData = { export const psvpInterface = new ethers.utils.Interface([ 'function initialize(address)', 'function executeProposal(bytes,tuple(address,uint256,bytes)[],uint256)', + 'function isEditor(address _account) view returns (bool)', + 'function isMember(address _account) view returns (bool)', + 'function submitAcceptSubspace(address _subspaceDao, address _spacePlugin)', + 'function submitEdits(string _contentUri, address _spacePlugin)', + 'function submitNewEditor(address _newEditor)', + 'function submitNewMember(address _newMember)', + 'function submitRemoveEditor(address _editor)', + 'function submitRemoveMember(address _member)', + 'function submitRemoveSubspace(address _subspaceDao, address _spacePlugin)', ]); describe('Personal Space Admin Plugin', function () { @@ -233,7 +242,7 @@ describe('Personal Space Admin Plugin', function () { .executeProposal('0x', actions, 0) ) .to.emit(spacePlugin, 'EditsPublished') - .withArgs('0x'); + .withArgs(dao.address, '0x'); }); it('Executed content proposals emit an event', async () => { @@ -264,7 +273,7 @@ describe('Personal Space Admin Plugin', function () { .executeProposal('0x', actions, 0) ) .to.emit(spacePlugin, 'EditsPublished') - .withArgs('0x'); + .withArgs(dao.address, '0x'); }); it('Approved subspaces emit an event', async () => { @@ -295,7 +304,7 @@ describe('Personal Space Admin Plugin', function () { .executeProposal('0x', actions, 0) ) .to.emit(spacePlugin, 'SubspaceAccepted') - .withArgs(ADDRESS_TWO); + .withArgs(dao.address, ADDRESS_TWO); }); it('Removed subspaces emit an event', async () => { @@ -340,7 +349,7 @@ describe('Personal Space Admin Plugin', function () { .executeProposal('0x', actionsRemove, 0) ) .to.emit(spacePlugin, 'SubspaceRemoved') - .withArgs(ADDRESS_TWO); + .withArgs(dao.address, ADDRESS_TWO); }); });