BUG: version 10.0.0 reintroduces agentOptions, but does not pass it down correctly

[phal0r]

In createHost additional agentOptions can be passed to configure undici (

arangojs/src/connection.ts

Line 62 in c13259a

function createHost(arangojsHostUrl: string, agentOptions?: any): Host {

). Unfortunately in all calls, the agentOptions are not passed down to this function, so there is no way to actually configure undici.

References, where createHost is called:

• arangojs/src/connection.ts

  Line 1019 in c13259a

  this._hosts.push(...newUrls.map((url) => createHost(url)));

• arangojs/src/connection.ts

  Line 996 in c13259a

  return createHost(url);

As you can easily spot in the functions, that call createHost, they already lack the additional parameters. Took some time to get down to this as I want to allow self signed certs and couldn't figure out why it fails, although I passed the params in every possible way and combination.

[pluma]

Oops! Quite the oversight, sorry about that. I guess I accidentally dropped that during refactoring.

The Connection class should store the config.agentOptions in a protected property _agentOptions and use that when calling createHost:

arangojs/src/connection.ts

Line 702 in c13259a

constructor(config: Omit<configuration.ConfigOptions, "databaseName"> = {}) {

Seems significant enough that we'd want to ship a bugfix for this.

I'm no longer going to be with ArangoDB next month so @cmyk47 or @shd8 might want to take a look at this.

[robross0606]

Since connection is also constructed in Database constructor, this means you cannot set agentOptions anywhere..?

arangojs/src/databases.ts

Line 207 in c13259a

this._connection = new connection.Connection(options);

[robross0606]

Is there any plan to fix this any time soon? It is a rather glaring bug which prevents us from adopting 10.0 at all.