Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servers that edit and sends the player's message as a server message does not get their emoji converted #44

Open
TheFlagen430297 opened this issue Mar 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@TheFlagen430297
Copy link

Describe the bug

Hello :)

I have encountered a bug that when the user sends an emoji, it won't work when the server sends it back.

Let me explain further

The emojis work when you are writing them in the text box:
image

They work on signs:
image

They work on single-player worlds:
image

They do not work on servers that edit the message to add stuff like Nicknames, Prefixes, Suffixes, etc:
image

This is because the server technically cancels the player's message and replaces it with a server message.
Server Messages do not get processed for emojis, as seen here:
image

I view that as a bug, but it would also be nice to be a feature if server messages would also be able to (I guess you could say) post emojis as well

Which side have you encountered the bug on?

Client

Steps to reproduce

  1. Go onto a server that edits messages of players.
  2. Send a chat message that should include an emoji.
  3. It won't be included.

Logs

https://mclo.gs/htpGVdd

Additional context

No response

@TheFlagen430297 TheFlagen430297 added the bug Something isn't working label Mar 2, 2024
@aratakileo
Copy link
Owner

Damn, this seems to be due to the hashing of messages by the mod. This hashing is used to separate the modified messages needed to display emojis and the unchanged messages that are sent to the server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants