Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pa11y-ci accessibility check for frontend #1334

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abhiram6121
Copy link

Closes #1304

Copy link

vercel bot commented Oct 17, 2024

@abhiram6121 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the github Github workflows label Oct 17, 2024
@abhiram6121 abhiram6121 marked this pull request as ready for review October 17, 2024 21:09
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 11:01pm

@abhiram6121
Copy link
Author

@dartpain

@dartpain
Copy link
Contributor

dartpain commented Oct 21, 2024

Hey it looks good but I have a few concerns / issues:

  1. Lets remove /about page from the list as its was depriciated recently
  2. Is there a dependency from a more popular repo, or something that we can pin to avoid any injections into our CI
  3. What are the main differences between fork and main repo?

thank you!

@abhiram6121
Copy link
Author

Hey it looks good but I have a few concerns / issues:

  1. Lets remove /about page from the list as its was depriciated recently
  2. Is there a dependency from a more popular repo, or something that we can pin to avoid any injections into our CI
  3. What are the main differences between fork and main repo?

thank you!

  1. Ok
  2. I’m not sure, probably not.
  3. The fork is primarily intended to actively maintain dependency updates, so we can easily revert to the original version if they start maintaining it again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github Github workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Pa11y CI pipeline check
2 participants